New TreeModel [WIP] #201
Merged
New TreeModel [WIP] #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds, but a bunch of signals and field ties are broken.
…tion, not SubPath(1)
Each Data()/SetData() was individually tracing the FieldPath before. Now they delegate to GetSubModel(), which should allow simpler access to other helpers, like GetDisplayIcon(), as well.
Also extract some methods from PrimitiveModel.h into a new PrimitiveModel.cpp before it gets out of hand.
Apparently there's no convenient way to tell a list view not to display the text along with the image, so adds a boilerplate header with a delegate class to do just that.
RobertBColton
force-pushed
the
NewTreeModel
branch
from
a1a9961 to
d370865
Compare
JoshDreamland
commented
Jul 21, 2021
| if (node->IsRepeated()) { | ||
| //return node->mapFromSource(node->repeated_model->duplicate(mapToSource(index))); | ||
| } | ||
| Node *parent = IndexToNode(index.parent()); |
There was a problem hiding this comment.
PLEASE check these; each one of these is capable of returning null, and the safety checks I added only work if you actually verify that I didn't return null.
| return QModelIndex(); | ||
| QModelIndex TreeModel::duplicateNode(const QModelIndex & index) { | ||
| Node *node = IndexToNode(index); | ||
| if (node->IsRepeated()) { |
There was a problem hiding this comment.
Like this change. But please just leave the if() commented if it's not being used.
RobertBColton
force-pushed
the
NewTreeModel
branch
from
7d433e5 to
cb5f3ce
Compare
fundies
approved these changes
Sep 6, 2021
This was referenced Oct 22, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit breaks almost everything. Successor to #144.
Redoes the ProtoModel family of classes to not know about our specific protos. Disclaimer: some references may still exist, but are unnecessary for the resource tree to function. If I missed any references, they're used by, eg, one of the editor classes.
I am basically finished modifying the Model classes and need to start updating the editors to use zero-based field indexing rather than field numbers. I believe Robert has done this work already, so I decided to stop where I was and create this pull request.
I believe we should be able to consolidate this with Robert's PR and have something pretty close to the finished product.
Currently broken: