ProtoModel improvements #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ance to prevent crash on dbl click, force the room editor to constantly redraw
…ance to prevent crash on dbl click, force the room editor to constantly redraw
This stops various views of the model from shitting all over the data while the removal is under way.
JoshDreamland
commented
Dec 8, 2019
| <string>Room</string> | ||
| </property> | ||
| <property name="windowIcon"> | ||
| <iconset resource="../../RGM_/images.qrc"> |
There was a problem hiding this comment.
I wish we could refer to this folder any way other than ../../RGM_...
| bkg = bkg->GetSubModel(TreeNode::kBackgroundFieldNumber); | ||
| if (!bkg) continue; | ||
|
|
||
| int x = sortedTiles->data(sortedTiles->index(row, Room::Tile::kXFieldNumber)).toInt(); |
There was a problem hiding this comment.
I... wouldn't do this. I'd add int_data() to the model that just asks the proto for an int32 directly. This is probably a big part of why the room editor spins up my fan so bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successor to #76. Fixes some issues with ProtoModels, and adds new functionality.