Add move/insert to repeated protomodel & add shader and timeline editors #79
Conversation
|
|
||
| StackedCodeWidget::StackedCodeWidget(QWidget* parent) : QStackedWidget(parent) {} | ||
|
|
||
| void StackedCodeWidget::newSource() { |
There was a problem hiding this comment.
Does this happen a lot? Consider extracting a template that delegates methods to its type.
| @@ -12,7 +12,7 @@ class PathEditor : public BaseEditor { | |||
|
|
|||
| public: | |||
| explicit PathEditor(ProtoModelPtr model, QWidget* parent); | |||
| ~PathEditor(); | |||
| ~PathEditor() override; | |||
There was a problem hiding this comment.
This is a very positive style of change... it'd be nice if we could get clang-tidy checks for stuff like this. Are we building with -Wall?
There was a problem hiding this comment.
nope.
-- 'CMAKE_C_FLAGS_DEBUG': -g
-- 'CMAKE_C_FLAGS_MINSIZEREL': -Os -DNDEBUG
-- 'CMAKE_C_FLAGS_RELEASE': -O3 -DNDEBUG
-- 'CMAKE_C_FLAGS_RELWITHDEBINFO': -O2 -g -DNDEBUG
-- 'CMAKE_CXX_FLAGS_DEBUG': -g -fno-omit-frame-pointer -fsanitize=address
-- 'CMAKE_CXX_FLAGS_MINSIZEREL': -Os -DNDEBUG
-- 'CMAKE_CXX_FLAGS_RELEASE': -O3 -DNDEBUG
-- 'CMAKE_CXX_FLAGS_RELWITHDEBINFO': -O2 -g -DNDEBUG
|
|
||
| cursorPositionLabel = new QLabel(); | ||
| this->updateCursorPositionLabel(ui->roomPreview->widget()->cursor().pos()); | ||
| assetNameLabel = new QLabel("obj_xxx"); |
There was a problem hiding this comment.
yes that was there before. robert wrote that
| @@ -114,7 +121,8 @@ void SoundEditor::on_loadButton_clicked() { | |||
| // QString newData = GetModelData(Sound::kDataFieldNumber).toString(); | |||
| // TODO: Copy data into our egm and reset the path | |||
| // SetModelData(Sound::kDataFieldNumber, lastData); | |||
| } else qDebug() << "Failed to load gmx sound"; | |||
| } else | |||
| qDebug() << "Failed to load gmx sound"; | |||
There was a problem hiding this comment.
Did clang-format do this? It should have put {} around this else clause.
There was a problem hiding this comment.
it did but i dont think clang format puts brackets
| case CppType::CPPTYPE_BOOL: | ||
| refl->SetBool(protobuf, field, value.toBool()); | ||
| break; | ||
| case CppType::CPPTYPE_INT32: refl->SetInt32(protobuf, field, value.toInt()); break; |
There was a problem hiding this comment.
I am struggling to believe that clang-format did this, but I don't mind it.
|
|
||
| connect(ui->stepBox, QOverload<int>::of(&QSpinBox::valueChanged), [=](int value) { CheckDisableButtons(value); }); | ||
|
|
||
| connect(ui->changeMomentButton, &QPushButton::pressed, [=]() { |
There was a problem hiding this comment.
Some of these lambdas are big enough to extract into members.
No description provided.