buggy paths #82

fundies · 2020-01-05T03:23:53Z

This PR adds support for paths, refactors asset drawing to allow drawing out of bounds, expands the grid in room editor to the whole window, changes room to only redraw on model updates, and probably 3 other things I forgot.

fundies · 2020-01-07T07:19:54Z

@JoshDreamland this ready for review now

fundies · 2020-01-07T08:11:58Z

This does crash seemingly randomly when I spam the delete button sometimes with qvector out of range error but I cant reproduce it regularly

JoshDreamland · 2020-01-08T01:16:25Z

Widgets/AssetScrollArea.h

+
+#include <QScrollArea>
+
+class AssetScrollArea : public QScrollArea {


In the not-too-distant future: please add middle-click panning to this widget.

You can pan with the keyboard. If you want mouse panning feel free to amend this pr or you can create an issue so someone else can add it later. It's not a priority for me.

I worry that's not discoverable. These editors are primarily mouse-driven.

Widgets/AssetScrollAreaBackground.cpp

JoshDreamland · 2020-01-08T03:55:41Z

Models/RepeatedProtoModel.h

-        field(m->protobuf->GetReflection()
-               ->GetMutableRepeatedFieldRef<Message>(m->protobuf, m->field)) {}
+    RowRemovalOperation(RepeatedProtoModelPtr m)
+        : model(m), field(m->protobuf->GetReflection()->GetMutableRepeatedFieldRef<Message>(m->protobuf, m->field)) {}


Your clang-format config seems to have a long line width set.

So it's taking code that was wrapped to 80-char limits (the norm) and re-wrapping it to something more like 200.

I have 120 set. Robert and I felt 80 was too low

JoshDreamland · 2020-01-08T03:57:14Z

Models/RepeatedProtoModel.cpp

@@ -159,6 +160,14 @@ bool RepeatedProtoModel::insertRows(int row, int count, const QModelIndex &paren
  return true;
 }

+void RepeatedProtoModel::RecursiveDataChanged() {


Technically this function's not recursive... it's traversing an inheritance hierarchy.

Ok transvestite datachanged or whatever it is

whats the actual word for this?

Iterative, but you probably just want to call it DataChangedThroughHierarchy or DataChangedForParents or something.

Widgets/AssetScrollAreaBackground.h

JoshDreamland · 2020-01-08T04:24:39Z

Widgets/BackgroundView.cpp

-              gridWidth, gridHeight);
+  if (model->data(Background::kUseAsTilesetFieldNumber).toBool()) {
+    grid.show = true;
+    grid.horSpacing = model->data(Background::kHorizontalSpacingFieldNumber).toInt();


In the future, it might be cool to allow binding the ScrollAreaBackground to these fields, directly. Especially if we add a UI-specific field to paths for persisting grid settings, as we've done for rooms.

Incidentally, maybe we should consider extracting those into a file we can .gitignore, eg, roomname.rm.ide.

Widgets/RoomView.cpp

JoshDreamland · 2020-01-08T04:45:10Z

Widgets/ResourceSelector.h

+
+class ResourceSelector : public QToolButton {
+ public:
+  explicit ResourceSelector(QWidget* parent, TreeNode::TypeCase type = TreeNode::TypeCase::kObject)


I feel dirty defaulting this to object. This is just so this constructor can serve as the default, yes?

Without a default argument the designer's generated code craps out. I can default the type to none if you prefer but I do need a default

JoshDreamland

The way you implemented room rendering in the path editor is pretty cool. I will think about how to use this when we go to add Overworlds. I think we'll need to add a caching layer to it, so that when rendering at less than 25% scale, only the cached version is used.

Anyway, if you're done, I'll merge this.

JoshDreamland · 2020-01-08T14:59:37Z

Editors/BackgroundEditor.cpp

@@ -80,7 +82,8 @@ void BackgroundEditor::on_actionLoadImage_triggered() {
        // QString newData = GetModelData(Background::kImageFieldNumber).toString();
        // TODO: Copy data into our egm and reset the path
        // SetModelData(Background::kImageFieldNumber, lastData);
-      } else qDebug() << "Failed to load gmx Background";
+      } else
+        qDebug() << "Failed to load gmx Background";


How strange... I thought we were using Google's. Have they pushed out an update?

JoshDreamland · 2020-01-08T15:03:36Z

Editors/PathEditor.cpp

 }

 PathEditor::~PathEditor() { delete ui; }
+
+void PathEditor::RebindSubModels() {
+  pathModel = _model->GetSubModel(TreeNode::kPathFieldNumber);


I see. So these are (or at least _model is) a weak pointer, and the editor will simply close when this would otherwise go stale. Sounds fine, although might lead to annoying behavior around, eg, undoing and redoing add or delete operations.

JoshDreamland · 2020-01-08T15:04:41Z

Editors/PathEditor.cpp

+      }
+    }
+  }
+  return QWidget::eventFilter(obj, event);


I should clarify: I get why we call it in general, but I'm not sure we should be calling it when we've already handled the event. But assuming you're seeing the right behavior for events we are handling here, this should be fine.

Widgets/RoomView.cpp

fundies · 2020-01-08T15:21:09Z

The way you implemented room rendering in the path editor is pretty cool. I will think about how to use this when we go to add Overworlds. I think we'll need to add a caching layer to it, so that when rendering at less than 25% scale, only the cached version is used.

Anyway, if you're done, I'll merge this.

I would like to rename your "shitty curve" functions can you come up with better names and I will rename that plus my datachanged crap. then should be good to merge

JoshDreamland · 2020-01-09T19:04:23Z

We can use "approximate curve" or something.

JoshDreamland · 2020-01-09T19:04:48Z

So apparently control-enter closes and comments...?

buggy paths

3f388b2

JoshDreamland mentioned this pull request Jan 5, 2020

Path editor #83

Closed

fundies added 3 commits January 5, 2020 15:22

better

939388b

dammit qt

cf2b17d

think we good now

b9b3aaa

fundies added 2 commits January 7, 2020 07:24

fix save btn

e9d7b2e

remember selected room

51ceee4

JoshDreamland approved these changes Jan 8, 2020

View reviewed changes

fundies added 2 commits January 8, 2020 12:43

less lambas, fix some of josh's nitpicks

cf2e7aa

oopsie

638060f

JoshDreamland reviewed Jan 8, 2020

View reviewed changes

JoshDreamland closed this Jan 9, 2020

JoshDreamland reopened this Jan 9, 2020

fundies added 2 commits January 9, 2020 22:48

vetter names

8072a59

better names

52dd2f1

JoshDreamland merged commit 4b0c8aa into enigma-dev:master Jan 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

buggy paths #82

buggy paths #82

fundies commented Jan 5, 2020 •

edited

Loading

fundies commented Jan 7, 2020

fundies commented Jan 7, 2020

JoshDreamland Jan 8, 2020

fundies Jan 8, 2020 •

edited

Loading

JoshDreamland Jan 8, 2020

JoshDreamland Jan 8, 2020

fundies Jan 8, 2020

JoshDreamland Jan 8, 2020

fundies Jan 8, 2020

JoshDreamland Jan 8, 2020

fundies Jan 8, 2020

fundies Jan 8, 2020

JoshDreamland Jan 8, 2020

JoshDreamland Jan 8, 2020

JoshDreamland Jan 8, 2020

fundies Jan 8, 2020

JoshDreamland left a comment •

edited

Loading

JoshDreamland Jan 8, 2020

JoshDreamland Jan 8, 2020

JoshDreamland Jan 8, 2020

fundies commented Jan 8, 2020 •

edited

Loading

JoshDreamland commented Jan 9, 2020

JoshDreamland commented Jan 9, 2020


		#include <QScrollArea>

		class AssetScrollArea : public QScrollArea {

buggy paths #82

buggy paths #82

Conversation

fundies commented Jan 5, 2020 • edited Loading

fundies commented Jan 7, 2020

fundies commented Jan 7, 2020

Choose a reason for hiding this comment

fundies Jan 8, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoshDreamland left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fundies commented Jan 8, 2020 • edited Loading

JoshDreamland commented Jan 9, 2020

JoshDreamland commented Jan 9, 2020

fundies commented Jan 5, 2020 •

edited

Loading

fundies Jan 8, 2020 •

edited

Loading

JoshDreamland left a comment •

edited

Loading

fundies commented Jan 8, 2020 •

edited

Loading