Fix QScintilla2 CMake Issues #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's qscintilla2 underscore qt5 dot dll for me in MinGW64.
RobertBColton
changed the title
…fix-azure-qscintilla
JoshDreamland
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's
qscintilla2_qt5.dllfor me in MinGW64 and thus Azure so I added that plus a bunch of other possibilities from a find qscintilla CMakeLists I found online. Then it was able to find the dll, link it, and fundies installer copied it.I had to remove
CodeWidgetPlain.cppfrom the sources list because fundies forgot to when he added the find library for qscintilla2 condition. Once I made it find the dll, we were getting multiple definition errors from linking both code widgets until I did this.Finally, I had to investigate why line numbers were not working and the editor diagnostics was reporting "signal not found in QsciScintilla" in the log window. It turns out that
-DQSCINTILLA_DLLis what happens when youCONFIG += qscintilla2in the qmake pro. That definition is needed to tell QScintilla we are using it as a shared library, otherwise it thinks we are using it as a static library.And I added a neat little message in here to show that we found QScintilla and where we found it. The result of this is the Azure artifact in this pull request seems to use QScintilla and it has line numbers.