tests: Try to reconnect to websocket once every second if the connection was closed #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run integration tests, the browser will get started and a new connection to a websocket will be established. If the test is done, the browser will continue to run but the other side will close the websocket. If another test is ran afterwards, it will not be able to establish a connection, because the browser will not try to connect.
This commit makes the browser try to reconnect every second. The messages get stored in a queue while no connection is established and they will get sent once a new connection was established. It might help prevent failed tests when the websocket gets closed for other reasons too.