Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standalone version of the simple WS #532

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

DaSpood
Copy link
Collaborator

@DaSpood DaSpood commented Jul 15, 2024

Add standalone mode for ServiceClient WS: client will redirect to other WS if the ID's matching IP is different from the local one.

Add IP<>ID conversion helpers to jqm-shared.

Missing:

  • Set the DB's ID sequence in the engine in standalone mode
  • End-to-end tests to see if requests are properly dispatched

@DaSpood DaSpood marked this pull request as draft July 15, 2024 14:39
@DaSpood DaSpood changed the title Draft: Add standalone version of the simple WS Add standalone version of the simple WS Jul 15, 2024
@ArnaudChirat
Copy link
Collaborator

What should we do

  • Update com/enioka/jqm/ws/api/ServiceClient.java to make the routing between the two client (avoiding breaking change)
  • Add a new parameters into GlobalParameters to set standalone mode
  • For new PR -> Set the sequence during database init -> see where and then move IPResolver into this Module

@DaSpood DaSpood force-pushed the ago/standalone-ws branch 2 times, most recently from 8745f81 to cead364 Compare July 19, 2024 07:53
@DaSpood DaSpood marked this pull request as ready for review July 19, 2024 07:55
@DaSpood DaSpood force-pushed the ago/standalone-ws branch from cead364 to 1103b00 Compare July 19, 2024 07:59
@DaSpood DaSpood force-pushed the ago/standalone-ws branch from 1103b00 to 63395ed Compare July 19, 2024 08:05
@ArnaudChirat ArnaudChirat merged commit ee641c5 into feat/standalone Jul 19, 2024
5 of 9 checks passed
standaloneMode = Boolean.parseBoolean(
GlobalParameter.getParameter(DbManager.getDb().getConn(), "wsStandaloneMode", "false"));

if (standaloneMode) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be add a check if standalone and db != from hsqldb than error "not supported"

ArnaudChirat pushed a commit that referenced this pull request Jul 29, 2024
* Add standalone version of the simple WS

* Modify ServiceClient instead of ServiceSimple
ArnaudChirat pushed a commit that referenced this pull request Oct 2, 2024
* Add standalone version of the simple WS

* Modify ServiceClient instead of ServiceSimple
ArnaudChirat added a commit that referenced this pull request Oct 2, 2024
* Database initialisation overhaul with Liquibase

As those databases don't have sequence, add autoincrement for mysql and mariadb.
For info, Maria db now support create sequence

* Update all Id type for model from int to long (#534)

Id became BIGINT into database
Use only primitive type UNLESS is nullable according to the database schema (Liquibase).
Update CI to test only on LTS database

* Add standalone version of the simple WS (#532)

* Add kubernetes template for standalone deployment (#538)

* Merge kube-specific deploy files with docker ones

---------

Co-authored-by: Marc-Antoine Gouillart <marsu_pilami@msn.com>
Co-authored-by: Antoine Gonzalez <perso.antoine.gonzalez@gmail.com>
Co-authored-by: Antoine Gonzalez <antoine.gonzalez@enioka.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants