Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Npm and tsc build fails on 5.13.0 due to bun-types #478

Closed
antego opened this issue May 14, 2023 · 2 comments · May be fixed by a11ywatch/core#429
Closed

Npm and tsc build fails on 5.13.0 due to bun-types #478

antego opened this issue May 14, 2023 · 2 comments · May be fixed by a11ywatch/core#429
Labels
bug Something isn't working released Has been released and published

Comments

@antego
Copy link

antego commented May 14, 2023

Expected Behaviour
Build started by tsc -b tsconfig.json passes

Actual Behaviour
Build fails with the error

node_modules/graphql-ws/lib/use/ws.d.ts:1:23 - error TS2688: Cannot find type definition file for 'bun-types'.

1 /// <reference types="bun-types" />

Debug Information
Failing version is 5.13.0

Further Information
Revert to version 5.12.1 fixes the problem
@enisdenjo
Copy link
Owner

Oooh, seems like TS build added the triple-slash directive to all declaration files - even though its only in the use/bun.ts. Sorry about that, fix incoming!

@enisdenjo enisdenjo added the bug Something isn't working label May 15, 2023
enisdenjo pushed a commit that referenced this issue May 15, 2023
@semantic-release-bot
chore(release): 🎉 5.13.1 [skip ci]
98ddc0b 
## [5.13.1](v5.13.0...v5.13.1) (2023-05-15)

### Bug Fixes

* Remove unnecessary bun-types directives ([e9a56f7](e9a56f7)), closes [#478](#478)
@enisdenjo
Copy link
Owner

🎉 This issue has been resolved in version 5.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@enisdenjo enisdenjo added the released Has been released and published label May 15, 2023
@j-mendez j-mendez mentioned this issue Aug 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released Has been released and published
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade graphql-ws from 5.13.1 to 5.16.0 a11ywatch/core
2 participants
@antego @enisdenjo