Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make code and reason optional when closing a connection #547

Closed
tobiasdiez opened this issue Mar 23, 2024 · 2 comments · May be fixed by a11ywatch/core#429
Closed

Make code and reason optional when closing a connection #547

tobiasdiez opened this issue Mar 23, 2024 · 2 comments · May be fixed by a11ywatch/core#429
Labels
enhancement New feature or request released Has been released and published

Comments

@tobiasdiez
Copy link
Contributor

Small thing, but

graphql-ws/src/server.ts

Line 420 in 6013eb5

): (code: number, reason: string) => Promise<void>; // closed

requires a code and reason, while the specs say that the status code is optional ("MAY indicate a reason").
@enisdenjo
Copy link
Owner

Conventionally you'd always specify the two. Also, you I want the users to always be clear and explicit about their closes. However, I have no hard reason to keep the two required - would you be interested in opening a PR? 😄

@enisdenjo enisdenjo added the enhancement New feature or request label Mar 23, 2024
enisdenjo pushed a commit that referenced this issue Mar 27, 2024
@semantic-release-bot
chore(release): 🎉 5.16.0 [skip ci]
325fe1a 
# [5.16.0](v5.15.0...v5.16.0) (2024-03-27)

### Bug Fixes

* **server:** Return all subscriptions regardless of the return invocation order ([f442288](f442288))
* **server:** should not send error messages if socket closes before onSubscribe hooks resolves ([db47a66](db47a66)), closes [#539](#539)

### Features

* **server:** Close code and reason are optional ([6ae6e6f](6ae6e6f)), closes [#547](#547)
@enisdenjo
Copy link
Owner

🎉 This issue has been resolved in version 5.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@enisdenjo enisdenjo added the released Has been released and published label Mar 27, 2024
@arddluma arddluma mentioned this issue May 22, 2024
Closed
@j-mendez j-mendez mentioned this issue Aug 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released Has been released and published
Projects
None yet
Milestone
No milestone
2 participants
@tobiasdiez @enisdenjo