Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Setup table is empty if input dataset has fewer than 100 rows #52

Closed
hydrosquall opened this issue Jul 25, 2024 · 2 comments
Closed

Comments

@hydrosquall
Copy link
Contributor

hydrosquall commented Jul 25, 2024

Meta

Bug report for latentscope===0.3.0, on MacOS, using python 3.12.1

Steps to reproduce

When embedding a smaller dataset (fewer than 100 rows), the /datasets/<name>/setup page renders an empty table. For example, with 29 rows we get an empty table.

image

This is accompanied with a server log

image

Based on the server log, I assume the backend is trying to retrieve data for rows (29 to 100), but erroring as those don't exist.

Fix ideas

We could

  1. change the frontend to request fewer rowss
  2. modify the backend to handle requests for large # of indexes more gracefully
  3. Something else (let the user choose the page size?)
@enjalot
Copy link
Owner

enjalot commented Jul 25, 2024

thanks for pointing this out, i went ahead and modified the backend to only try and return valid indices

@hydrosquall
Copy link
Contributor Author

hydrosquall commented Jul 25, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants