[PLA-1915] Fixes beams encoding

[leonardocustodio]

PR Type

Bug fix, Enhancement

---

Description

• Added import for BatchMintMutation to handle specific batch minting logic.
• Updated the processBatch method to include conditional logic for BatchMint encoding.
• Fixed an encoding issue related to the php-scale-codec library when using BatchMint.
• Ensured transactions are correctly stored with the appropriate encoded data.

---

Changes walkthrough 📝

	Relevant files
Bug fix	BatchProcess.php Fix and enhance batch processing for beam encoding              src/Commands/BatchProcess.php Added import for BatchMintMutation. Updated processBatch method to handle BatchMint encoding separately. Introduced conditional logic to fix encoding issues with BatchMint. Ensured transactions are stored with correct encoded data. +17/-4

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Hardcoded Logic The conditional logic for handling 'BatchMint' uses hardcoded checks and specific method names, which might lead to maintenance issues if the method names or logic change in the future. Consider using a more dynamic approach or configuration-driven logic. TODO Comment There is a 'TODO' comment indicating an unresolved issue with the 'php-scale-codec' library. This should be addressed or tracked in an issue tracker to ensure it does not get overlooked.

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Security	Add validation for collectionId and recipients to ensure they are correct before processing Ensure that the collectionId and recipients parameters are properly validated before they are used in the encoding process. This can prevent issues related to invalid data being processed and improve the security of the transaction handling. src/Commands/BatchProcess.php [212-219] +if (!isValidCollectionId($param['collectionId']) || !isValidRecipients($param['recipients'])) { + throw new InvalidArgumentException("Invalid collection ID or recipients"); +} collectionId: $param['collectionId'], recipients: $param['recipients'], Suggestion importance[1-10]: 10 Why: Validating collectionId and recipients before processing is essential for preventing issues related to invalid data. This enhances the security and reliability of the transaction handling process.	10
Possible issue	Add exception handling around the encoding process to manage failures gracefully It's recommended to handle potential exceptions that might be thrown by the encode method or any other operations within the conditional blocks to prevent runtime errors and ensure the application's robustness. src/Commands/BatchProcess.php [211-215] -$encodedData = $this->serialize->encode( 'Batch', BatchMintMutation::getEncodableParams( - collectionId: $param['collectionId'], - recipients: $param['recipients'], - continueOnFailure: true -)); +try { + $encodedData = $this->serialize->encode( 'Batch', BatchMintMutation::getEncodableParams( + collectionId: $param['collectionId'], + recipients: $param['recipients'], + continueOnFailure: true + )); +} catch (Exception $e) { + // Handle encoding failure + logError($e); + return; +} Suggestion importance[1-10]: 9 Why: Adding exception handling is crucial for managing potential runtime errors, ensuring the robustness of the application. This suggestion addresses a significant issue that could lead to application crashes.	9
Maintainability	Refactor the encoding logic into a separate method to enhance maintainability To improve code maintainability and avoid repetition, consider refactoring the encoding logic into a separate method. This will make the code cleaner and easier to manage, especially if the encoding logic needs to be updated or debugged in the future. src/Commands/BatchProcess.php [211-220] -$encodedData = $this->serialize->encode( 'Batch', BatchMintMutation::getEncodableParams( - collectionId: $param['collectionId'], - recipients: $param['recipients'], - continueOnFailure: true -)); -$encodedData = $this->serialize->encode(isRunningLatest() ? $method . 'V1010' : $method, [ - 'collectionId' => $param['collectionId'], - 'recipients' => $param['recipients'], -]); +$encodedData = encodeTransactionData($method, $param); +// New method to encapsulate encoding logic +function encodeTransactionData($method, $param) { + if ($method === 'BatchMint') { + return $this->serialize->encode( 'Batch', BatchMintMutation::getEncodableParams( + collectionId: $param['collectionId'], + recipients: $param['recipients'], + continueOnFailure: true + )); + } else { + return $this->serialize->encode(isRunningLatest() ? $method . 'V1010' : $method, [ + 'collectionId' => $param['collectionId'], + 'recipients' => $param['recipients'], + ]); + } +} Suggestion importance[1-10]: 8 Why: Refactoring the encoding logic into a separate method improves code maintainability and readability. It makes future updates and debugging easier, which is beneficial for long-term code management.	8
Best practice	Add a check to ensure the uniqueness of the idempotency_key before usage Consider checking the result of Str::uuid()->toString() for uniqueness before using it as an idempotency_key to ensure that the key is truly unique and has not been used before. This can prevent potential issues with duplicate transactions. src/Commands/BatchProcess.php [226] -'idempotency_key' => Str::uuid()->toString(), +$uniqueId = Str::uuid()->toString(); +// Ensure the UUID is unique by checking against a database or cache +while (!isUniqueIdValid($uniqueId)) { + $uniqueId = Str::uuid()->toString(); +} +'idempotency_key' => $uniqueId, Suggestion importance[1-10]: 7 Why: Ensuring the uniqueness of the idempotency_key is a good practice to prevent potential issues with duplicate transactions. However, the implementation of isUniqueIdValid and the performance impact of repeatedly generating UUIDs should be considered.	7