[PLA-1970] Optimize remove claim token listener

[enjinabner]

PR Type

enhancement

---

Description

• Enhanced the RemoveClaimToken listener by adding checks for the existence of a collection before proceeding with token operations.
• Optimized the logic for handling token and beam claims, improving performance and readability.
• Replaced the each method with more efficient query operations to handle beam claims and cache decrements.
• Improved the cache decrement logic by directly working with beam codes.

---

Changes walkthrough 📝

	Relevant files
Enhancement	RemoveClaimToken.php Optimize and enhance the RemoveClaimToken listener logic  src/Listeners/RemoveClaimToken.php Added checks for collection existence before proceeding. Optimized token and beam claim handling logic. Replaced each with more efficient query operations. Improved cache decrement logic for beams. +28/-16

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Possible Bug The new implementation checks for the existence of a collection and token, but does not handle the case where the token might not exist or might not be non-fungible. This could lead to unexpected behavior if the token conditions are not met. Performance Issue The new implementation queries the database multiple times for the same token and collection IDs. It would be more efficient to query once and store the results, or to refactor the conditions to minimize database hits.

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Performance	Consolidate multiple database queries into a single query to improve performance To avoid potential performance issues with multiple database queries, consider consolidating the two separate queries on BeamClaim into a single query. This will reduce the overhead of executing similar queries multiple times and improve the efficiency of the database interaction. src/Listeners/RemoveClaimToken.php [30-38] $beamsToDecrement = BeamClaim::where('token_chain_id', $event->broadcastData['tokenId']) ->where('collection_id', $collection->id) ->claimable() - ->pluck('beam_id'); + ->pluck('beam_id') + ->tap(function ($beamIds) { + BeamClaim::whereIn('id', $beamIds)->delete(); + }); -BeamClaim::where('token_chain_id', $event->broadcastData['tokenId']) - ->where('collection_id', $collection->id) - ->claimable() - ->delete(); - Suggestion importance[1-10]: 9 Why: Consolidating the queries reduces the number of database interactions, which can significantly improve performance and reduce overhead. This is a crucial optimization for efficiency.	9
Possible issue	Add checks for empty collections before proceeding with further operations To avoid potential issues with empty results from the pluck method, add a condition to check if $beamsToDecrement is not empty before proceeding with the Beam query and cache decrement operations. src/Listeners/RemoveClaimToken.php [30-42] $beamsToDecrement = BeamClaim::where('token_chain_id', $event->broadcastData['tokenId']) ->where('collection_id', $collection->id) ->claimable() ->pluck('beam_id'); -Beam::whereIn('id', $beamsToDecrement) - ->get(['id', 'code']) - ->each(fn ($beam) => Cache::decrement(BeamService::key($beam->code))); +if ($beamsToDecrement->isNotEmpty()) { + Beam::whereIn('id', $beamsToDecrement) + ->get(['id', 'code']) + ->each(fn ($beam) => Cache::decrement(BeamService::key($beam->code))); +} Suggestion importance[1-10]: 8 Why: Adding a check for empty collections prevents unnecessary operations and potential errors, enhancing the robustness and efficiency of the code.	8
Possible bug	Add null checks before performing cache operations to prevent errors To ensure that the cache decrement operation is only performed on valid Beam instances, add a check to verify that the Beam object retrieved is not null before attempting to decrement the cache. src/Listeners/RemoveClaimToken.php [40-42] Beam::whereIn('id', $beamsToDecrement) ->get(['id', 'code']) - ->each(fn ($beam) => Cache::decrement(BeamService::key($beam->code))); + ->each(function ($beam) { + if ($beam) { + Cache::decrement(BeamService::key($beam->code)); + } + }); Suggestion importance[1-10]: 7 Why: Adding a null check ensures that the cache operation is only performed on valid objects, preventing potential runtime errors. This is a good practice for robustness.	7
Maintainability	Use more descriptive variable names to enhance code readability To enhance code readability and maintainability, consider using a more descriptive variable name than $collection for the Collection model instance. A name like $targetCollection would provide more context about the role of the variable in the code. src/Listeners/RemoveClaimToken.php [21-23] -if (!$collection = Collection::where('collection_chain_id', $event->broadcastData['collectionId'])->first()) { +if (!$targetCollection = Collection::where('collection_chain_id', $event->broadcastData['collectionId'])->first()) { return; } Suggestion importance[1-10]: 6 Why: Using a more descriptive variable name improves code readability and maintainability, though it is a minor improvement compared to functional changes.	6