Fix source for batch transfer

[enjinabner]

PR Type

enhancement, bug fix

---

Description

• Enhanced the logic for determining the source in batch transfers by using a match expression, improving readability and logic flow.
• Added CollectionService to the imports to check for approval existence in the collection.
• Fixed a bug where the source was incorrectly determined for batch transfers.

---

Changes walkthrough 📝

	Relevant files
Enhancement	BatchProcess.php Enhance source determination logic for batch transfer        src/Commands/BatchProcess.php Added CollectionService to imports. Updated logic for determining the source in batch transfer. Used a match expression to enhance readability and logic flow. +9/-3

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[github-actions]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Logic Improvement The use of the match expression in line 163 improves readability and logic flow for determining the source. However, ensure that the default case (null) is the intended behavior when no conditions are met.

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Performance	Optimize performance by resolving services outside loops Ensure that the resolve function is not called within the loop for performance reasons. Calling resolve repeatedly in a loop can lead to performance degradation, especially if the resolved service is complex to build. Consider resolving CollectionService outside the loop and reusing it. src/Commands/BatchProcess.php [164-165] -resolve(CollectionService::class)->approvalExistsInCollection( - $collectionId, - Account::daemonPublicKey() -) => Account::daemonPublicKey(), +$collectionService = resolve(CollectionService::class); +'source' => match(true) { + $collectionService->approvalExistsInCollection( + $collectionId, + Account::daemonPublicKey() + ) => Account::daemonPublicKey(), + Account::daemonPublicKey() !== $claim->collection->owner->public_key => $claim->collection->owner->public_key, + default => null +}, Suggestion importance[1-10]: 9 Why: This suggestion addresses a potential performance issue by avoiding repeated service resolution within a loop. It is a significant improvement for performance optimization.	9
Best practice	Refactor complex match logic into a separate method Extract the complex logic within the match expression into a separate method to enhance code readability and reusability. This method can handle the logic of determining the source based on conditions, which can be unit tested separately for correctness. src/Commands/BatchProcess.php [163-169] -'source' => match(true) { - resolve(CollectionService::class)->approvalExistsInCollection( - $collectionId, - Account::daemonPublicKey() - ) => Account::daemonPublicKey(), - Account::daemonPublicKey() !== $claim->collection->owner->public_key => $claim->collection->owner->public_key, - default => null -}, +'source' => $this->getSource($collectionId, $claim), Suggestion importance[1-10]: 8 Why: This suggestion is similar to the first one but emphasizes reusability and testability, which are best practices. It is a good improvement for code quality and maintainability.	8
Reliability	Add error handling for service method calls to enhance robustness Add error handling for the case where CollectionService::approvalExistsInCollection might return an unexpected result or throw an exception. This will make the code more robust and prevent runtime errors in production. src/Commands/BatchProcess.php [164-165] -resolve(CollectionService::class)->approvalExistsInCollection( - $collectionId, - Account::daemonPublicKey() -) => Account::daemonPublicKey(), +try { + $approvalExists = resolve(CollectionService::class)->approvalExistsInCollection( + $collectionId, + Account::daemonPublicKey() + ); +} catch (\Exception $e) { + // Handle exception or log error + $approvalExists = false; // Default to false or handle as needed +} +'source' => match(true) { + $approvalExists => Account::daemonPublicKey(), + Account::daemonPublicKey() !== $claim->collection->owner->public_key => $claim->collection->owner->public_key, + default => null +}, Suggestion importance[1-10]: 8 Why: Adding error handling increases the robustness of the code by preventing unexpected runtime errors, which is crucial for production stability. This is a valuable enhancement for reliability.	8
Maintainability	Simplify the source determination logic using a dedicated method Replace the match expression with a more readable conditional logic structure to improve maintainability and readability. The match expression can be confusing due to its complexity and multiple conditions. Using a series of if and else statements will make the code easier to understand and maintain. src/Commands/BatchProcess.php [163-169] -'source' => match(true) { - resolve(CollectionService::class)->approvalExistsInCollection( - $collectionId, - Account::daemonPublicKey() - ) => Account::daemonPublicKey(), - Account::daemonPublicKey() !== $claim->collection->owner->public_key => $claim->collection->owner->public_key, - default => null -}, +'source' => $this->determineSource($collectionId, $claim), Suggestion importance[1-10]: 7 Why: Extracting the logic into a separate method can improve readability and maintainability, but it doesn't address any critical issues or bugs. The suggestion is valid and enhances code organization.	7