You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardcoded Value The bind port is hardcoded to 8090 in spawnServer function. Consider making it configurable via environment variables or configuration files to enhance flexibility.
Why: This suggestion improves maintainability by allowing the port number to be configured via an environment variable, aligning with the existing pattern for other settings.
9
Dynamically log the application version from an environment variable
Update the version log message to dynamically fetch the version from a single source of truth to avoid manual updates in multiple places.
Why: This suggestion improves maintainability by reducing the need for manual updates of the version number in multiple places, though it requires the version to be set in the environment.
7
Error handling
Add error handling for environment variable parsing
Consider adding error handling or logging for the parsing operations to ensure that any issues with environment variables are clearly reported.
Why: Adding error handling for environment variable parsing enhances robustness by ensuring that parsing errors are logged, which aids in debugging and maintaining the application.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
enhancement, configuration changes
Description
defaultBindPort
variable frombin/server.dart
and set the bind port directly in thespawnServer
function.DEFAULT_BIND_PORT
from the.env.example
file.pubspec.yaml
file to bump the version from 2.1.0 to 2.1.1.Changes walkthrough 📝
server.dart
Remove default bind port variable and update version
bin/server.dart
defaultBindPort
variable.spawnServer
function..env.example
Remove DEFAULT_BIND_PORT from example environment file
.env.example
DEFAULT_BIND_PORT
entry.pubspec.yaml
Bump version to 2.1.1
pubspec.yaml