[PLA-1806] Class init error

[leonardocustodio]

PR Type

Bug fix

---

Description

• Fixed a potential class initialization error by making the FuelTank property nullable and initializing it to null.

---

Changes walkthrough 📝

	Relevant files
Bug fix	FuelTankCreated.php Make `FuelTank` property nullable and initialize to null  src/Services/Processor/Substrate/Events/Implementations/FuelTanks/FuelTankCreated.php Changed FuelTank property to be nullable. Initialized FuelTank property to null. +1/-1

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the PR involves a simple change in a single file with a clear purpose, making it relatively straightforward to review.
🧪 Relevant tests	No
⚡ Possible issues	Possible Null Reference: Making FuelTank nullable could lead to null reference exceptions elsewhere in the code if other parts of the codebase assume the fuelTankCreated property is always non-null.
🔒 Security concerns	No

Code feedback:

---

relevant file	src/Services/Processor/Substrate/Events/Implementations/FuelTanks/FuelTankCreated.php
suggestion	Consider adding a check for null before using the fuelTankCreated property in methods that depend on it. This will prevent potential null reference exceptions that could occur due to this change. [important]
relevant line	protected ?FuelTank $fuelTankCreated = null;

---

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Best practice	Move initialization of properties to the constructor for better clarity and management Consider initializing the fuelTankCreated property within the constructor of the class rather than at the point of declaration. This approach enhances clarity by centralizing initialization logic and can help manage dependencies more effectively if the initialization depends on constructor parameters in the future. src/Services/Processor/Substrate/Events/Implementations/FuelTanks/FuelTankCreated.php [21] -protected ?FuelTank $fuelTankCreated = null; +protected ?FuelTank $fuelTankCreated; +public function __construct() { + $this->fuelTankCreated = null; +} + Suggestion importance[1-10]: 7 Why: Moving the initialization of the fuelTankCreated property to the constructor can improve code clarity and maintainability by centralizing initialization logic. However, the current initialization at the point of declaration is also a valid approach, and the improvement is relatively minor.	7

[enjinabner]

some comment

stale