[PLA-1900] Adds default value to provides deposit

[leonardocustodio]

PR Type

Bug fix

---

Description

• Added a default value of false to the provides_deposit field in the FuelTankCreated event to prevent potential null value issues.

---

Changes walkthrough 📝

	Relevant files
Bug fix	FuelTankCreated.php Add default value for `provides_deposit` field                      src/Services/Processor/Substrate/Events/Implementations/FuelTanks/FuelTankCreated.php Added a default value of false to the provides_deposit field. +1/-1

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ No key issues to review

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible issue	Improve the handling of null values for 'provides_deposit' to avoid unintended coercion of falsy values Consider using a more explicit check for null when setting the default value for 'provides_deposit'. This ensures that only null values are replaced with false, and all other falsy values like 0, empty strings, or arrays are not unintentionally coerced to false. src/Services/Processor/Substrate/Events/Implementations/FuelTanks/FuelTankCreated.php [54] -'provides_deposit' => $providesDeposit ?? false, +'provides_deposit' => isset($providesDeposit) ? $providesDeposit : false, Suggestion importance[1-10]: 9 Why: The suggestion correctly identifies a potential issue with the use of the null coalescing operator (??), which can unintentionally coerce other falsy values to false. The proposed change to use isset ensures that only null values are replaced with false, improving the robustness of the code.	9