[PLA-2055] Fixes RuleSets on CreateFuelTank

[leonardocustodio]

PR Type

enhancement

---

Description

• Removed dispatch rules handling from FuelTankCreated.php, simplifying the run method.
• Refactored RuleSetInserted.php by adding methods to handle rule parsing and dispatch rule creation.
• Improved code maintainability by separating logic into distinct methods.

---

Changes walkthrough 📝

Relevant files

Enhancement

FuelTankCreated.php Remove dispatch rules handling from FuelTankCreated            src/Services/Processor/Substrate/Events/Implementations/FuelTanks/FuelTankCreated.php Removed handling of dispatch rules from the run method. Simplified the run method by eliminating unused code. +0/-19    RuleSetInserted.php Refactor rule parsing and dispatch rule creation                  src/Services/Processor/Substrate/Events/Implementations/FuelTanks/RuleSetInserted.php Modified rule retrieval logic in the run method. Added methods parseTankCreatedRuleSets and parseRuleSetInsertedRuleSet. Refactored dispatch rule creation logic into separate methods. +41/-14

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Code Removal The removal of dispatch rules handling could impact existing functionalities. Ensure that this change does not affect other parts of the system that might rely on these rules. Method Complexity The new methods parseTankCreatedRuleSets and parseRuleSetInsertedRuleSet introduce additional complexity and potential for errors in rule parsing. It's crucial to ensure these methods are robust and well-tested.

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Add validation for $rules to ensure data integrity before processing Validate the structure and content of $rules before processing them in parseTankCreatedRuleSets and parseRuleSetInsertedRuleSet to prevent potential errors from malformed data. src/Services/Processor/Substrate/Events/Implementations/FuelTanks/RuleSetInserted.php [40] -$insertDispatchRules = empty(Arr::get($rules, '0.1.rules')) ? $this->parseRuleSetInsertedRuleSet($rules) : $this->parseTankCreatedRuleSets($rules); +if (validateRulesStructure($rules)) { + $insertDispatchRules = empty(Arr::get($rules, '0.1.rules')) ? $this->parseRuleSetInsertedRuleSet($rules) : $this->parseTankCreatedRuleSets($rules); +} Suggestion importance[1-10]: 8 Why: This suggestion is highly relevant as it proposes adding validation for $rules which is crucial to prevent errors from malformed data. Ensuring data integrity before processing is a best practice that enhances the robustness of the code.	8
	Ensure the removal of dispatch rules handling is intentional and managed correctly Ensure that the removal of dispatch rules handling does not lead to unintended side effects or data inconsistencies. If dispatch rules are still relevant, consider reintroducing the handling logic or ensure that their management is appropriately migrated to another part of the application. src/Services/Processor/Substrate/Events/Implementations/FuelTanks/FuelTankCreated.php [70] $this->fuelTankCreated->accountRules()->createMany($insertAccountRules); +// Consider reintroducing dispatch rules handling here if necessary Suggestion importance[1-10]: 7 Why: The suggestion is relevant as it addresses the removal of dispatch rules handling, which could lead to data inconsistencies if not managed properly. The suggestion to reintroduce or manage this aspect elsewhere is crucial for maintaining application integrity.	7