[PLA-1621] New daemon version

[leonardocustodio]

Type

enhancement, configuration changes

---

Description

• Removed the entire content of configs/daemon/start.sh and configs/daemon/Dockerfile, indicating a significant change in how the daemon is deployed or started.
• Updated docker-compose.yml to reflect changes in the daemon's Dockerfile location and added environment variables and volume for configuration.
• Updated the wallet-daemon submodule to a newer commit, suggesting enhancements or bug fixes in the daemon's functionality.

---

Changes walkthrough

	Relevant files
Configuration changes	start.sh Removal of Daemon Start Script                                                      configs/daemon/start.sh Entire script content removed. +0/-8      Dockerfile Dockerfile Content Removal                                                              configs/daemon/Dockerfile Dockerfile content completely removed. +0/-48    docker-compose.yml Docker Compose Configuration Update for Daemon Service      docker-compose.yml Updated build context and Dockerfile location for the daemon service. Added environment file and volume for config.json in daemon service. +5/-2
Enhancement	wallet-daemon Wallet Daemon Subproject Update                                                    wallet-daemon Subproject commit updated to a new version. +1/-1

---

✨ Usage guide:

---

Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:

/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:

[pr_description]
some_config1=...
some_config2=...

Enabling\disabling automation When you first install the app, the default mode for the describe tool is: pr_commands = ["/describe --pr_description.add_original_user_description=true" "--pr_description.keep_original_user_title=true", ...] meaning the describe tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description. Markers are an alternative way to control the generated description, to give maximal control to the user. If you set: pr_commands = ["/describe --pr_description.use_description_markers=true", ...] the tool will replace every marker of the form pr_agent:marker_name in the PR description with the relevant content, where marker_name is one of the following: type: the PR type. summary: the PR summary. walkthrough: the PR walkthrough. Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

Custom labels The default labels of the describe tool are quite generic: [Bug fix, Tests, Enhancement, Documentation, Other]. If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases. Examples for custom labels: Main topic:performance - pr_agent:The main topic of this PR is performance New endpoint - pr_agent:A new endpoint was added in this PR SQL query - pr_agent:A new SQL query was added in this PR Dockerfile changes - pr_agent:The PR contains changes in the Dockerfile ... The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases. Note that Labels are not mutually exclusive, so you can add multiple label categories. Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.

Inline File Walkthrough 💎 For enhanced user experience, the describe tool can add file summaries directly to the "Files changed" tab in the PR page. This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs). To enable inline file summary, set pr_description.inline_file_summary in the configuration file, possible values are: 'table': File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab. true: A collapsable file comment with changes title and a changes summary for each file in the PR. false (default): File changes walkthrough will be added only to the "Conversation" tab.

Utilizing extra instructions The describe tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description. Examples for extra instructions: [pr_description] extra_instructions=""" - The PR title should be in the format: '<PR type>: <title>' - The title should be short and concise (up to 10 words) - ... """ Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

More PR-Agent commands To invoke the PR-Agent, add a comment using one of the following commands: /review: Request a review of your Pull Request. /describe: Update the PR title and description based on the contents of the PR. /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback. /ask <QUESTION>: Ask a question about the PR. /update_changelog: Update the changelog based on the PR's contents. /add_docs 💎: Generate docstring for new components introduced in the PR. /generate_labels 💎: Generate labels for the PR based on the PR's contents. /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

[github-actions]

PR Description updated to latest commit (6f545c5)

[github-actions]

PR Review

PR feedback
⏱️ Estimated effort to review [1-5]	2, because the PR involves significant configuration changes and removal of scripts, which requires understanding the context and the impact of these changes on the project. The update to the wallet-daemon submodule suggests that there might be enhancements or bug fixes that need to be reviewed in the context of these configuration changes.
🧪 Relevant tests	No
🔍 Possible issues	The removal of the start.sh script and the entire Dockerfile content in configs/daemon/Dockerfile might impact the deployment or startup process of the daemon. It's crucial to ensure that these changes are aligned with the updated deployment strategy and that all necessary configurations are correctly migrated to the new setup. The update in docker-compose.yml to change the Dockerfile context and add environment variables and volumes requires careful review to ensure that the daemon service will still function as expected in the new configuration.
🔒 Security concerns	No

Code feedback:

---

relevant file	docker-compose.yml
suggestion	Ensure that the new context and dockerfile path in the daemon service of docker-compose.yml are correctly pointing to the updated Dockerfile location. This change is crucial for the build process to find the Dockerfile in the new location. [important]
relevant line	dockerfile: Dockerfile

---

relevant file	docker-compose.yml
suggestion	Verify that the environment variables and volumes specified in the daemon service of docker-compose.yml are correctly configured and necessary for the daemon's operation. This includes the new .env file and config.json volume. [important]
relevant line	env_file:

---

relevant file	configs/daemon/Dockerfile
suggestion	Since the content of configs/daemon/Dockerfile was removed, ensure that any required dependencies, previously installed in the Dockerfile, are now handled appropriately in the new Dockerfile location or setup. [important]
relevant line	-FROM debian as sources

---

relevant file	configs/daemon/start.sh
suggestion	Confirm that the functionality previously provided by start.sh script is either no longer needed or has been appropriately migrated to the new startup process. This might include environment variable setup or running the wallet daemon. [important]
relevant line	-#!/bin/bash

---

---

✨ Usage guide:

---

Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

Utilizing extra instructions The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize. Examples for extra instructions: [pr_reviewer] # /review # extra_instructions=""" In the 'possible issues' section, emphasize the following: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

How to enable\disable automation When you first install PR-Agent app, the default mode for the review tool is: pr_commands = ["/review", ...] meaning the review tool will run automatically on every PR, with the default configuration. Edit this field to enable/disable the tool, or to change the used configurations

Auto-labels The review tool can auto-generate two specific types of labels for a PR: a possible security issue label, that detects possible security issues (enable_review_labels_security flag) a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

Extra sub-tools The review tool provides a collection of possible feedbacks about a PR. It is recommended to review the possible options, and choose the ones relevant for your use case. Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example: require_score_review, require_soc2_ticket, and more.

Auto-approve PRs By invoking: /review auto_approve The tool will automatically approve the PR, and add a comment with the approval. To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following: [pr_reviewer] enable_auto_approval = true (this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository) You can also enable auto-approval only if the PR meets certain requirements, such as that the estimated_review_effort is equal or below a certain threshold, by adjusting the flag: [pr_reviewer] maximal_review_effort = 5

More PR-Agent commands To invoke the PR-Agent, add a comment using one of the following commands: /review: Request a review of your Pull Request. /describe: Update the PR title and description based on the contents of the PR. /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback. /ask <QUESTION>: Ask a question about the PR. /update_changelog: Update the changelog based on the PR's contents. /add_docs 💎: Generate docstring for new components introduced in the PR. /generate_labels 💎: Generate labels for the PR based on the PR's contents. /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

[github-actions]

PR Code Suggestions

	Suggestions
best practice	Use a specific version tag for Docker images to ensure reproducibility.       Specify a tag for the enjin/daemon image instead of using latest to ensure reproducibility and avoid unexpected changes when the latest tag is updated. docker-compose.yml [111] -image: enjin/daemon:latest +image: enjin/daemon:<specific-version> Use absolute paths for volume mounts to avoid path issues.                    Use absolute paths for volume mounts to avoid potential issues with relative paths, especially when the Docker Compose file is run from different directories. docker-compose.yml [119] volumes: - - ./configs/daemon/config.json:/opt/app/config.json + - /absolute/path/to/configs/daemon/config.json:/opt/app/config.json Define a custom network for services to ensure isolation.                     To avoid potential conflicts and ensure network isolation, define a custom network for your services in the docker-compose.yml file. docker-compose.yml [121-122] -extra_hosts: - - "host.docker.internal:host-gateway" +networks: + custom_network: + driver: bridge +services: + daemon: + networks: + - custom_network
enhancement	Add depends_on to ensure services start in the correct order.    Consider adding a depends_on configuration for services that the daemon depends on, to ensure they are started in the correct order. docker-compose.yml [110] daemon: + depends_on: + - other-service
security	Specify non-root user for better security.                                    For better security, consider specifying non-root user in the Dockerfile and reflect that in the volume permissions to prevent potential security vulnerabilities. docker-compose.yml [119] volumes: - ./configs/daemon/config.json:/opt/app/config.json +user: non-root-user

---

✨ Usage guide:

---

Overview:
The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.
When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:

/improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...

With a configuration file, use the following template:

[pr_code_suggestions]
some_config1=...
some_config2=...

Enabling\disabling automation When you first install the app, the default mode for the improve tool is: pr_commands = ["/improve --pr_code_suggestions.summarize=true", ...] meaning the improve tool will run automatically on every PR, with summarization enabled. Delete this line to disable the tool from running automatically.

Utilizing extra instructions Extra instructions are very important for the improve tool, since they enable to guide the model to suggestions that are more relevant to the specific needs of the project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify relevant aspects that you want the model to focus on. Examples for extra instructions: [pr_code_suggestions] # /improve # extra_instructions=""" Emphasize the following aspects: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

A note on code suggestions quality While the current AI for code is getting better and better (GPT-4), it's not flawless. Not all the suggestions will be perfect, and a user should not accept all of them automatically. Suggestions are not meant to be simplistic. Instead, they aim to give deep feedback and raise questions, ideas and thoughts to the user, who can then use his judgment, experience, and understanding of the code base. Recommended to use the 'extra_instructions' field to guide the model to suggestions that are more relevant to the specific needs of the project, or use the custom suggestions 💎 tool With large PRs, best quality will be obtained by using 'improve --extended' mode.

More PR-Agent commands To invoke the PR-Agent, add a comment using one of the following commands: /review: Request a review of your Pull Request. /describe: Update the PR title and description based on the contents of the PR. /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback. /ask <QUESTION>: Ask a question about the PR. /update_changelog: Update the changelog based on the PR's contents. /add_docs 💎: Generate docstring for new components introduced in the PR. /generate_labels 💎: Generate labels for the PR based on the PR's contents. /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the improve usage page for a more comprehensive guide on using this tool.