Skip to content

Commit

Permalink
Do not install ffi gem automatically on Windows platforms
Browse files Browse the repository at this point in the history
We originally introduced this logic in #132 without understanding all
the implications.

Issue #158 raised a challenge with this approach.
  • Loading branch information
sds committed Sep 20, 2019
1 parent 1a2382a commit ca709e5
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 29 deletions.
3 changes: 3 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ source 'http://rubygems.org'
# Specify your gem's dependencies in child_process.gemspec
gemspec

# Used for local development/testing only
gem 'rake'

if RUBY_VERSION =~ /^1\./
gem 'tins', '< 1.7' # The 'tins' gem requires Ruby 2.x on/after this version
gem 'json', '< 2.0' # The 'json' gem drops pre-Ruby 2.x support on/after this version
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ a standalone library.

* Ruby 2.3+, JRuby 9+

Windows users **must** ensure the `ffi` gem (`>= 1.0.11`) is installed in order to use ChildProcess.

# Usage

The object returned from `ChildProcess.build` will implement `ChildProcess::AbstractProcess`.
Expand Down
5 changes: 0 additions & 5 deletions childprocess.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,4 @@ Gem::Specification.new do |s|
s.add_development_dependency "rspec", "~> 3.0"
s.add_development_dependency "yard", "~> 0.0"
s.add_development_dependency 'coveralls', '< 1.0'

s.add_runtime_dependency 'rake', '< 13.0'

# Install FFI gem if we're running on Windows
s.extensions = 'ext/mkrf_conf.rb'
end
24 changes: 0 additions & 24 deletions ext/mkrf_conf.rb

This file was deleted.

0 comments on commit ca709e5

Please sign in to comment.