Support newer rspec-expectations
#138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `spec/childprocess_spec.rb` rspec compatible with rubygem-rspec-expectations-3.7.0-3.fc29.1.noarch (Tested on Fedora Rawhide.)
4 similar comments
Closed
|
Hey @pvalena, thanks for the pull request. Any particular reason you changed the check to Otherwise this looks good to merge. Let us know! |
|
FWIW, I'm able to run these tests without issue on rspec-expectations 3.8.0. I'm going to close this as it's not clear to me from the PR description why this is necessary, but would be more than happy to merge once justification is provided. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
spec/childprocess_spec.rbrspec compatible withrubygem-rspec-expectations-3.7.0-3.fc29.1.noarch
(Tested on Fedora Rawhide.)