Fix argument delegation (Ruby 3x) #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, using childprocess in a Ruby 3 environment would generate `wrong number of arguments` errors. This commit attempts to address the errors by ensuring that we are properly delegating arguments in childprocess and the abstract_process classes.
|
Hey @jarib @enkessler @sds - I noticed that you were all owners of this gem on rubygems.org. Would it be possible to get some help with this PR? Thank you 😄 |
This commit updates msvcrt_name to return the value of RUBY_SO_NAME or ucrtbase. Change taken from enkessler#182.
|
@sds thanks so much for merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, using childprocess in a Ruby 3 environment would generate
wrong number of argumentserrors.This change attempts to address the errors by ensuring that we are properly delegating arguments in childprocess and the abstract_process classes.
Tests appear to pass locally on Ruby 3.2.0.
Happy to take direction/feedback.