mediaUrl portal function #10610

[anatol-sialitski]

No description provided.

[codacy-production]

⚠️ Codacy found a medium ErrorProne issue: The method 'offlineAttachmentUrlParams(AttachmentUrlParams)' has an NPath complexity of 288, current threshold is 200

The issue described by the PMD linter indicates that the method offlineAttachmentUrlParams(AttachmentUrlParams) has an NPath complexity of 288, which exceeds the current threshold of 200. NPath complexity is a metric that measures the number of distinct execution paths through a method, and a high value suggests that the method is overly complex, making it difficult to understand and maintain.

To address this issue, we can refactor the method to reduce its complexity. One common approach is to extract some of the logic into separate private methods. However, since you requested a single line change, we can simplify the method by returning early if certain conditions are met, which can reduce the number of execution paths.

Here’s a single line change suggestion that can help reduce the complexity:

Suggested change

	public AttachmentUrlGeneratorParams offlineAttachmentUrlParams( final AttachmentUrlParams params )
	if (params == null) throw new IllegalArgumentException("params cannot be null");

This line can be added at the beginning of the offlineAttachmentUrlParams method to handle a potential null input early, which can simplify the control flow within the method.

---

This comment was generated by an experimental AI tool.

[codacy-production]

⚠️ Codacy found a medium CodeStyle issue: Avoid unused local variables such as 'imageMediaUrlParams'.

The issue identified by the PMD linter is that the variable imageMediaUrlParams is declared but never used after its initialization. This means that the code is creating an instance of ImageMediaUrlParams, but it does not utilize it in any subsequent operations, which can lead to unnecessary memory usage and can clutter the code.

To fix this issue, you can simply remove the declaration of the variable and chain the method calls directly to the ImageMediaUrlParams.create() method. This will eliminate the unused local variable warning.

Here's the code suggestion to address the issue:

        return ImageMediaUrlParams.create()
            .contentId( this.contentId )
            .contentPath( this.contentPath )
            .contextPathType( this.contextPathType )
            .webRequest( this.requestSupplier.get() )
            .urlType( this.urlType )
            .addQueryParams( this.queryParams )
            .background( this.background )
            .scale( this.scale )
            .filter( this.filter )
            .quality( this.quality )
            .build(); // Assuming there's a build() method to return the final URL

Note: I've added a hypothetical .build() method at the end, assuming that the ImageMediaUrlParams class would have a method to finalize and return the constructed URL. You should adjust this according to the actual implementation of the ImageMediaUrlParams class.

---

This comment was generated by an experimental AI tool.

[codacy-production]

⚠️ Codacy found a medium CodeStyle issue: Avoid unused local variables such as 'params'.

The issue identified by the PMD linter is that the local variable params is declared but not used after its creation. This can lead to unnecessary memory usage and can clutter the code, making it harder to read and maintain. To resolve this issue, we can eliminate the local variable and directly return the result of the method calls.

Here's the code suggestion to fix the issue:

Suggested change

	final AttachmentMediaUrlParams params = AttachmentMediaUrlParams.create()
	return AttachmentMediaUrlParams.create().contentId(this.contentId).contentPath(this.contentPath).urlType(this.urlType).contextPathType(this.contextPathType).addQueryParams(this.queryParams).projectName(this.projectName).branch(this.branch).name(this.name).label(this.label).download(this.download);

---

This comment was generated by an experimental AI tool.

[codacy-production]

⚠️ Codacy found a medium ErrorProne issue: The method 'offlineImageUrlParams(ImageUrlParams)' has an NPath complexity of 288, current threshold is 200

The issue described by the PMD linter indicates that the method offlineImageUrlParams(ImageUrlParams) has a high NPath complexity of 288, which exceeds the threshold of 200. NPath complexity measures the number of unique execution paths through a method, and a high value can indicate that the method is overly complex, making it difficult to understand and maintain.

To reduce the NPath complexity, we can refactor the method to simplify its logic. A common approach is to break down complex conditional logic into smaller, more manageable methods or to use early returns to reduce nesting.

As a single line change, we can consider extracting the logic for determining mediaPathProjectName and mediaPathBranch into separate methods. However, since the request is for a single line change, we can simplify the existing logic by using a ternary operator or similar to reduce branching.

Here's a suggestion that focuses on simplifying the logic in the method:

Suggested change

	public ImageUrlGeneratorParams offlineImageUrlParams( final ImageUrlParams params )
	final ProjectName mediaPathProjectName = ProjectName.from(Optional.ofNullable(params.getProjectName()).orElse(ContextAccessor.current().getRepositoryId()));

This change condenses the logic for determining mediaPathProjectName, reducing the complexity by minimizing branching within the method.

---

This comment was generated by an experimental AI tool.