Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistence of whether to expect a model or collection #4

Open
enov opened this issue Oct 22, 2013 · 0 comments
Open

More consistence of whether to expect a model or collection #4

enov opened this issue Oct 22, 2013 · 0 comments

Comments

@enov
Copy link
Owner

enov commented Oct 22, 2013

To enhance the protected find_mode function, and be consistent of whether to return model or collection.

I think it is always good to return a collection, unless of very specific reasons where the developers expects or knows that Aurora will return a model. Those reasons can be summarized by the following:

  • The developer feeds a new model that should be retrieved.
  • The developer asks for model 'Model_Common_Name' see issue No 3
  • The developer feeds a scalar $params to load()

We should remove logic where Aurora tests for number of rows returned.

enov added a commit that referenced this issue Nov 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant