change db config back to active record config #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkim3162
changed the title
hkim3162
force-pushed
the
additional_changes_to_prodder_rails_upgrade
branch
4 times, most recently
from
139f29a to
b6e38d3
Compare
vbhat
previously approved these changes
Feb 28, 2023
hkim3162
force-pushed
the
additional_changes_to_prodder_rails_upgrade
branch
from
b6e38d3 to
f9c3351
Compare
rnubel
approved these changes
Mar 1, 2023
kaisensan
pushed a commit
that referenced
this pull request
Nov 19, 2024
…ils_upgrade change db config back to active record config
kaisensan
pushed a commit
that referenced
this pull request
Nov 19, 2024
…ils_upgrade change db config back to active record config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the effort to help make prodder support rails 6.1 due to deprecated methods. this passes linter and will work on rails 6.1 as the migration successfully completes.
I originally changed it all to use the config based on Rails config.