Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Poetry 1.3 with [poetry] extra #78

Closed
brandon-leapyear opened this issue Dec 20, 2022 · 3 comments · Fixed by #83
Closed

Use Poetry 1.3 with [poetry] extra #78

brandon-leapyear opened this issue Dec 20, 2022 · 3 comments · Fixed by #83

Comments

@brandon-leapyear
Copy link

I believe the only thing blocking this is updating

-cleo = {version = "^1.0.0a5", optional = true, allow-prereleases = true}
+cleo = {version = "^2.0.0", optional = true, allow-prereleases = true}
-poetry = {version = "^1.2.0", optional = true}
+poetry = {version = "^1.3.0", optional = true}
@nejch
Copy link

nejch commented Feb 20, 2023

Default ranges created by poetry when adding deps are almost always too restrictive for libraries like this plugin. It mostly only has applications in mind for default behavior IMO.

Maybe a more open range would make sense? Otherwise library users will always have conflicts if they have other dependencies. See also #82 which is a similar problem although that's a major release so makes a bit more sense.

@enpaul
Copy link
Owner

enpaul commented Feb 24, 2023

Hi @brandon-leapyear sorry for the delay in response here. This is a good thing flag, I'll work on getting this out soon.

@nejch The restrictive dependency specification is one of the driving reasons behind #2 . Unfortunately that issue is currently blocked right now, but once done this plugin will drop a dependency on Poetry entirely.

@nejch
Copy link

nejch commented Feb 28, 2023

Thanks for looking into this @enpaul! Since #82 will probably stay blocked for a while, does it make sense to release this on pypi so people can use poetry 1.3 for the time being?

@nejch nejch mentioned this issue Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants