Fix/issue #2: Lorem picsum client hangs

[giulianopz]

As said in the commit message:

It seems the only reasonable thing to do, since the service does not enforce rate limiting as per this blogpost: https://dmarby.se/blog/lorem-picsum/.
Only clients generating a very high load are blocked at their cache layer.

I don't know if the timeout should be configurable via flag.

[enrichman]

Fair enough, I was looking for a golang Picsum client with no luck.

Did you reproduced the issue?

[giulianopz]

I was not able to reproduce the issue. The differences with regard to response times seem quite normal:

giulianopz@machine:~/git/stegosecrets(fix/issue-2-lorem-picsum-client-hangs)$ while sleep 0.1; do /bin/time -f "\t%E clock-wall time ([hours:]minutes:seconds)" ./stego images; done
        0:03.88 clock-wall time ([hours:]minutes:seconds)
        0:02.15 clock-wall time ([hours:]minutes:seconds)
        0:02.98 clock-wall time ([hours:]minutes:seconds)
        0:03.10 clock-wall time ([hours:]minutes:seconds)
        0:01.81 clock-wall time ([hours:]minutes:seconds)
        0:01.47 clock-wall time ([hours:]minutes:seconds)
        0:02.41 clock-wall time ([hours:]minutes:seconds)
        0:02.31 clock-wall time ([hours:]minutes:seconds)
        0:01.74 clock-wall time ([hours:]minutes:seconds)
        0:01.73 clock-wall time ([hours:]minutes:seconds)
        0:02.00 clock-wall time ([hours:]minutes:seconds)
        0:02.12 clock-wall time ([hours:]minutes:seconds)
        0:02.35 clock-wall time ([hours:]minutes:seconds)
        0:10.84 clock-wall time ([hours:]minutes:seconds)
        0:01.81 clock-wall time ([hours:]minutes:seconds)
        0:02.02 clock-wall time ([hours:]minutes:seconds)
        0:04.81 clock-wall time ([hours:]minutes:seconds)
        0:02.78 clock-wall time ([hours:]minutes:seconds)
        0:02.00 clock-wall time ([hours:]minutes:seconds)
        0:04.20 clock-wall time ([hours:]minutes:seconds)
        0:02.62 clock-wall time ([hours:]minutes:seconds)
        0:02.63 clock-wall time ([hours:]minutes:seconds)
        0:06.90 clock-wall time ([hours:]minutes:seconds)

Nevertheless, setting a timeout makes still sense probably.

[enrichman]

Yes, agree. Let's merge this, we still have lot of improvements that we are going to add!

Thanks