Write properties file at each iteration when using OpenMC #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RonRahaman I just updated this branch so that tests pass (there was an upstream bug in OpenMC that needed to be fixed). Would appreciate a review whenever you get a chance. |
|
This will be super useful. Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenMC now has the ability to write a "properties" file which includes temperature/density information (openmc-dev/openmc#1852). This PR updates the OpenMC submodule and changes
OpenmcDriver::write_stepto write a properties file for each iteration. Along with proposed changes in openmc-plotter, this allows us to easily visualize temperature/density distributions (on OpenMC's geometry).With the OpenMC update, I also needed to modify the geometry.xml files for the short/long rod tests to include more information for periodic boundary conditions.