Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting from Excel pastes Image #286

Closed
enricoros opened this issue Dec 20, 2023 · 6 comments
Closed

Pasting from Excel pastes Image #286

enricoros opened this issue Dec 20, 2023 · 6 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@enricoros
Copy link
Owner

When pasting from Excel, the Image part takes precedence over the Html (which would be turned into a nice markdown table) or Text

@enricoros enricoros added the good first issue Good for newcomers label Dec 20, 2023
@Just-A-Pixel
Copy link

I am interested in working on this issue.
May I understand what exactly is being copied from excel?

@enricoros
Copy link
Owner Author

Are you able to assign this one to yourself?

What happens is that when copying from apps, the clipboard has many formats inside. There's text/html, text/plain,... and image/png or something.

Need to make sure the right format is used, and not a picture.

@enricoros enricoros added this to the 1.11.0 milestone Jan 10, 2024
@vaibhavard
Copy link

vaibhavard commented Jan 11, 2024

I am interested in working on this issue. May I understand what exactly is being copied from excel?

Thanks @Just-A-Pixel for working on this issue. It was raised by me to @enricoros ...
Do you understand what the problems is.. . I can explain it if you want to :)

@enricoros enricoros modified the milestones: 1.11.0, 1.12.0 Jan 16, 2024
@enricoros enricoros self-assigned this Jan 16, 2024
@enricoros
Copy link
Owner Author

enricoros commented Jan 16, 2024

Fixed on main, NOTES BELOW

Application relation change:

  • Excel (tested on windows): pastes table instead of images
  • Word: pastes text (ctrl+v) or attaches text+html (shift+ctrl+v, paste button)
  • Powerpoint: ctrl+v pastes text as text, and non-text as image

Paste behavior change

Action Former behavior Now
CTRL+V paste image Paste table as text
Shift+Ctrl+V paste image Attach Table as Markdown
"Paste" Button paste image Attach Table as Markdown

@vaibhavard
Copy link

I appreciate the prompt resolution. The level of developer engagement and the pace of development observed in this GitHub repository are unparalleled in my experience. Thank you.
Shall i Close the issue ✅.

@enricoros
Copy link
Owner Author

Yep, issue closed (I put "Fixes #286" in the git commit title, which tells GitHub to auto-close. Magic :)

@enricoros enricoros mentioned this issue Jan 26, 2024
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants