Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve scrolling #304

Closed
6 of 7 tasks
enricoros opened this issue Dec 25, 2023 · 3 comments
Closed
6 of 7 tasks

Improve scrolling #304

enricoros opened this issue Dec 25, 2023 · 3 comments
Milestone
1.9.0

Comments

@enricoros
Copy link
Owner

enricoros commented Dec 25, 2023 •
edited
Loading

There's jumpiness on iOS by using the columns-reverse approach.

Consider using the react-scroll-to-bottom library.

Requirements:

  • evaluate library and dependencies and code increase
  • migrate from the *-reverse mechanism
  • add a button to scroll to bottom
  • test on Android, chrome
  • test on Firefox
  • In-line Free Scroll toggling  #59
  • test on iOS, Safari
@enricoros
Copy link
Owner Author

Won't use react-scroll-to-bottom, but will re-make a lib that works for us.

@enricoros enricoros moved this from Requests to In Progress in big-AGI build-in-public roadmap Dec 28, 2023
@enricoros enricoros added this to the 1.9.0 milestone Dec 28, 2023
enricoros added a commit that referenced this issue Dec 28, 2023
@enricoros
New UI - Part 1 - Details inside:
d775d47 
 - Optima Layout: new Context based pluggable layout system
   - Now children have context functions, for better behaviors
   - Removed `store-applayout`
   - using withLayout on top-level Pages
 - ScrollToBottom: grounds-up subsystem for smooth scrolling with snap-to-bottom
 - Panes subsystem: use react-resizeable-panels together with our Panes subsystem
   - New: Split window chats, Drag to close windows, Button to split
   - using: https://github.com/bvaughn/react-resizable-panels
 - Cosmetic: Colors: update Light and Dark themes
 - Bootstrap Logic provider: will enable Mobile use cases
 - Removed NoSSR (the backend provided natually acts as the same)
 - Next load progress: loading indicator for slower pages (>300ms)
 - withLayout() system

Additional benefits include: no-pluggable-flashing, pane-ready,
fixed X-scrolling on Firefox, and more.

Closes #308, #304, #255, #59.
Progress on #305, #201, #296, #233, #208, #203.
@github-project-automation github-project-automation bot moved this from In Progress to Ready in big-AGI build-in-public roadmap Dec 28, 2023
@enricoros enricoros mentioned this issue Dec 28, 2023
Closed
22 tasks
@LennardSchwarz
Copy link

I just tested on iOS and it works flawlessly! Amazing work. Love the little indicator, very intuititve.

@LennardSchwarz LennardSchwarz mentioned this issue Dec 30, 2023
Closed
@enricoros
Copy link
Owner Author

I just tested on iOS and it works flawlessly! Amazing work. Love the little indicator, very intuititve.

Thanks for testing! It was a full on and optimized rewrite. Very happy of the results, and smoother than before :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

No branches or pull requests
2 participants
@enricoros @LennardSchwarz