-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another Pull Request with style changes to prompting bar with tooltips and Content Mode #37
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks, I've reviewed this new version. Did you know your app is live already for anyone to use: link The quality of this patch has improved already, and glad you're figuring out the workflow to stay up to date on the latest changes. However, a couple of notes:
Here's what we should do: you can configure your IDE with Prettier so systems always minimize changes. I will not merge the pull request here (too many code changes, and there's a reason for the current UI to co-exist), but your fork of the repository has your UI and University-focused changes. |
Ah, makes sense. Yeah I was looking at it like "I didn't change that much". Turns out it is the formatter. I've used Prettier before but currently using Eslint so that's where that issue lies. Will change the formatter on my end for this project to keep consistency. On the note of the toggle for the bigger text box, that sounds like a small task so I'll focus on adding that to my version so there's options in the UI. My 2 cents on the Community Templates. The ideal goal is to have a marketplace style area that has different system messages that can be easily integrated for ultimate customization, however that could take a more intense hosting solution with the added database. I might start a small side project marketplace that prompts can be added to by users and voted up and down, and then I'll submit a pull request with an integration in the future that would allow people to select a prompt or upload a prompt. So yup, I'll continue on my own fork for now and will definitely be in touch soon as your and my version progress. |
i am super interested in this will
…On Fri, Mar 31, 2023 at 1:17 AM Will Scott-Rodriguez < ***@***.***> wrote:
Ah, makes sense.
Yeah I was looking at it like "I didn't change that much". Turns out it is
the formatter. I've used Prettier before but currently using Eslint so
that's where that issue lies. Will change the formatter on my end for this
project to keep consistency.
On the note of the toggle for the bigger text box, that sounds like a
small task so I'll focus on adding that to my version so there's options in
the UI.
My 2 cents on the Community Templates. The ideal goal is to have a
marketplace style area that has different system messages that can be
easily integrated for ultimate customization, however that could take a
more intense hosting solution with the added database. I might start a
small side project marketplace that prompts can be added to by users and
voted up and down, and then I'll submit a pull request with an integration
in the future that would allow people to select a prompt or upload a prompt.
So yup, I'll continue on my own fork for now and will definitely be in
touch soon as your and my version progress.
—
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABO2LTFM6QUTVNPF4HNQ7BDW6ZSFXANCNFSM6AAAAAAWOAR7MQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Thanks Will. Before I park this pull request: are you thinking of maintaining and hosting (e.g., Vercel) your fork? If so, I can add a link to your fork from the main readme, to send University users your way :) Lmk. Sounds great for the prompts, your feedback is great for #35 . |
Hey Yup, I'll self host this fork with a uni mode initially. Gotta make some other modifications over this weekend then I'll flick you a link. |
Thanks for your feedback, I've done another pull request with the most recent version.
I see you managed to fix a lot of the issues I was looking at doing and the split componentry is such a huge help!
Cheers
Will