Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another Pull Request with style changes to prompting bar with tooltips and Content Mode #37

Closed
wants to merge 2 commits into from

Conversation

willscottrod
Copy link

Thanks for your feedback, I've done another pull request with the most recent version.

I see you managed to fix a lot of the issues I was looking at doing and the split componentry is such a huge help!

Cheers
Will

@vercel
Copy link

vercel bot commented Mar 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nextjs-chatgpt-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 1:27AM (UTC)

@enricoros
Copy link
Owner

Thanks, I've reviewed this new version.

Did you know your app is live already for anyone to use: link

The quality of this patch has improved already, and glad you're figuring out the workflow to stay up to date on the latest changes. However, a couple of notes:

  • somehow the commit adds +131 lines of code and removes −129. this is quite large, and would be overwritten by future code that I write. This is because the code is formatted by "Prettier" (https://prettier.io/) on my end, while (VSCode?) on your end applies different spacing and all. This translates in a lot of code being modified, and the patch being harder to maintain because the 2 systems would keep changing the code back and forth. Is there a "Prettier" plugin you can install on your IDE? After installing, load the rules in the ".prettierrc" file, and the systems will be on the same page
  • Change 1. UI: I like the looks actually, but also see the value in the existing UI for developers / people that need more space for the edit box (to drop files in, etc). I'm thinking on whether I should make it switchable, with an ON/OFF "ChatGPT-like UI" option.
  • Change 2. Prompt: I'm thinking about how to enable people to publish their prompts ("Content Mode") and tracking this in Personas: Add custom, dynamic, and persisted #35. I like your change, but cannot formally merge it because of the "undetectable" implications to the brand :)

Here's what we should do: you can configure your IDE with Prettier so systems always minimize changes. I will not merge the pull request here (too many code changes, and there's a reason for the current UI to co-exist), but your fork of the repository has your UI and University-focused changes.
You should maintain and publish your version whi (I use Vercel, free plan, and you can give it a domain), which focuses on students and UI, and I will continue modularizing and cleaning the base code, and adding core features. If you have core features and improvements, I'll merge them into the master code base, otherwise, you can maintain them. Sounds good?

@willscottrod
Copy link
Author

Ah, makes sense.

Yeah I was looking at it like "I didn't change that much". Turns out it is the formatter. I've used Prettier before but currently using Eslint so that's where that issue lies. Will change the formatter on my end for this project to keep consistency.

On the note of the toggle for the bigger text box, that sounds like a small task so I'll focus on adding that to my version so there's options in the UI.

My 2 cents on the Community Templates. The ideal goal is to have a marketplace style area that has different system messages that can be easily integrated for ultimate customization, however that could take a more intense hosting solution with the added database. I might start a small side project marketplace that prompts can be added to by users and voted up and down, and then I'll submit a pull request with an integration in the future that would allow people to select a prompt or upload a prompt.

So yup, I'll continue on my own fork for now and will definitely be in touch soon as your and my version progress.

@rossman22590
Copy link
Contributor

rossman22590 commented Mar 31, 2023 via email

@enricoros
Copy link
Owner

Thanks Will. Before I park this pull request: are you thinking of maintaining and hosting (e.g., Vercel) your fork?

If so, I can add a link to your fork from the main readme, to send University users your way :) Lmk.

Sounds great for the prompts, your feedback is great for #35 .

@willscottrod
Copy link
Author

Hey

Yup, I'll self host this fork with a uni mode initially.

Gotta make some other modifications over this weekend then I'll flick you a link.

@enricoros enricoros closed this Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants