forked from ros-navigation/navigation2
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Nacho/cleanup get transform util (ros-navigation#4181)
* remove unused header Signed-off-by: Ignacio Vizzo <ignacio@dexory.com> * First step. Return an optional value instead of user provided output. Signed-off-by: Ignacio Vizzo <ignacio@dexory.com> * Second step, update the consumers of this utility function Signed-off-by: Ignacio Vizzo <ignacio@dexory.com> * Third step: swap source/target to make it consistent with tf lookups Otherwise is very confusing for any user who is user to the tf2::Buffer::lookupTransform method Signed-off-by: Ignacio Vizzo <ignacio@dexory.com> * transform tolerance -> transform timeout I find this "transform tolerance" to specify something else. Once again, I believe that sticking to tf2 name conventions is better and improve readability for users already used to the tf2 API Signed-off-by: Ignacio Vizzo <ignacio@dexory.com> * Last step, convert functions to template functions This allow us to also query for the TransformStamped message from the lookupTransform method. Signed-off-by: Ignacio Vizzo <ignacio@dexory.com> * Add nodiscard to avoid confusiong API calls Signed-off-by: Ignacio Vizzo <ignacio@dexory.com> * Update docs Signed-off-by: Ignacio Vizzo <ignacio@dexory.com> * Revert "transform tolerance -> transform timeout" This reverts commit ca7d06b. Signed-off-by: Ignacio Vizzo <ignacio@dexory.com> * Fix linter 🤦 Signed-off-by: Ignacio Vizzo <ignacio@dexory.com> * reset to main Signed-off-by: Ignacio Vizzo <ignacio@dexory.com> * Add 2 new utils functions to query transforms using messages Signed-off-by: Ignacio Vizzo <ignacio@dexory.com> * Move utility function to base class to reuse implementation Signed-off-by: Ignacio Vizzo <ignacio@dexory.com> * Fix Typo Signed-off-by: Ignacio Vizzo <ignacio@dexory.com> --------- Signed-off-by: Ignacio Vizzo <ignacio@dexory.com> Signed-off-by: enricosutera <enricosutera@outlook.com>
- Loading branch information
1 parent
72dc8b5
commit 5575cd7
Showing
7 changed files
with
134 additions
and
83 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters