internal/build: don't crash in DownloadFile when offline (ethereum#20595

)
enriquefynn · Feb 15, 2021 · 190f899 · 190f899
1 parent 2a14d53
commit 190f899
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/internal/build/download.go b/internal/build/download.go
@@ -83,8 +83,10 @@ func (db *ChecksumDB) DownloadFile(url, dstPath string) error {
 	fmt.Printf("downloading from %s\n", url)
 
 	resp, err := http.Get(url)
-	if err != nil || resp.StatusCode != http.StatusOK {
-		return fmt.Errorf("download error: code %d, err %v", resp.StatusCode, err)
+	if err != nil {
+		return fmt.Errorf("download error: %v", err)
+	} else if resp.StatusCode != http.StatusOK {
+		return fmt.Errorf("download error: status %d", resp.StatusCode)
 	}
 	defer resp.Body.Close()
 	if err := os.MkdirAll(filepath.Dir(dstPath), 0755); err != nil {