Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FET-987: new avatar uploader #785

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion public/locales/en/transactionFlow.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,12 @@
"profileEditor": {
"tabs": {
"avatar": {
"change": "Change avatar",
"label": "Avatar",
"dropdown": {
"selectNFT": "Select NFT",
"uploadImage": "Upload Image"
"uploadImage": "Upload Image",
"enterManually": "Enter manually"
},
"nft": {
"title": "Select an NFT",
Expand Down
161 changes: 87 additions & 74 deletions src/components/@molecules/ProfileEditor/Avatar/AvatarButton.tsx
Original file line number Diff line number Diff line change
@@ -1,18 +1,13 @@
import { ComponentProps, Dispatch, SetStateAction, useRef } from 'react'
import { ComponentProps, useRef } from 'react'
import { useTranslation } from 'react-i18next'
import styled, { css } from 'styled-components'

import { Avatar, Dropdown } from '@ensdomains/thorin'
import { Avatar, Button, Dropdown, mq } from '@ensdomains/thorin'
import { DropdownItem } from '@ensdomains/thorin/dist/types/components/molecules/Dropdown/Dropdown'

import CameraIcon from '@app/assets/Camera.svg'
import { LegacyDropdown } from '@app/components/@molecules/LegacyDropdown/LegacyDropdown'

const Container = styled.button<{ $error?: boolean; $validated?: boolean; $dirty?: boolean }>(
const AvatarWrapper = styled.button<{ $error?: boolean; $validated?: boolean; $dirty?: boolean }>(
({ theme, $validated, $dirty, $error }) => css`
position: relative;
width: 90px;
height: 90px;
border-radius: 50%;
background-color: ${theme.colors.backgroundPrimary};
cursor: pointer;
Expand Down Expand Up @@ -61,29 +56,30 @@ const Container = styled.button<{ $error?: boolean; $validated?: boolean; $dirty
`,
)

const IconMask = styled.div(
const ActionContainer = styled.div(
({ theme }) => css`
position: absolute;
top: 0;
left: 0;
width: 90px;
height: 90px;
border-radius: 50%;
display: flex;
align-items: center;
justify-content: center;
background: linear-gradient(0deg, rgba(0, 0, 0, 0.6), rgba(0, 0, 0, 0.6));
border: 4px solid ${theme.colors.grey};
flex-direction: column;
align-items: flex-start;
gap: ${theme.space[2]};
overflow: hidden;
`,
)

svg {
width: 40px;
display: block;
}
const Container = styled.div(
({ theme }) => css`
width: 100%;
display: grid;
grid-template-columns: 120px 1fr;
align-items: center;
gap: ${theme.space[4]};
${mq.xs.max(css`
grid-template-columns: 80px 1fr;
`)}
`,
)

export type AvatarClickType = 'upload' | 'nft'
export type AvatarClickType = 'upload' | 'nft' | 'manual'

type PickedDropdownProps = Pick<ComponentProps<typeof Dropdown>, 'isOpen' | 'setIsOpen'>

Expand All @@ -100,8 +96,8 @@ type Props = {

const AvatarButton = ({
validated,
dirty,
error,
dirty,
src,
onSelectOption,
onAvatarChange,
Expand All @@ -125,59 +121,76 @@ const AvatarButton = ({
}

const dropdownProps = setIsOpen
? ({ isOpen, setIsOpen } as { isOpen: boolean; setIsOpen: Dispatch<SetStateAction<boolean>> })
? ({ isOpen, setIsOpen } as {
isOpen: boolean
setIsOpen: React.Dispatch<React.SetStateAction<boolean>>
})
: ({} as { isOpen: never; setIsOpen: never })

return (
<LegacyDropdown
items={
[
{
label: t('input.profileEditor.tabs.avatar.dropdown.selectNFT'),
color: 'black',
onClick: handleSelectOption('nft'),
},
{
label: t('input.profileEditor.tabs.avatar.dropdown.uploadImage'),
color: 'black',
onClick: handleSelectOption('upload'),
},
...(validated
? [
{
label: t('action.remove', { ns: 'common' }),
color: 'red',
onClick: handleSelectOption('remove'),
},
]
: []),
] as DropdownItem[]
}
keepMenuOnTop
shortThrow
{...dropdownProps}
>
<Container $validated={validated && dirty} $error={error} $dirty={dirty} type="button">
<Container>
<AvatarWrapper $validated={validated && dirty} $error={error} $dirty={dirty} type="button">
<Avatar label="profile-button-avatar" src={src} noBorder />
{!validated && !error && (
<IconMask>
<CameraIcon />
</IconMask>
)}
<input
type="file"
style={{ display: 'none' }}
accept="image/*"
ref={fileInputRef}
onChange={(e) => {
if (e.target.files?.[0]) {
onSelectOption?.('upload')
onAvatarFileChange?.(e.target.files[0])
}
}}
/>
</Container>
</LegacyDropdown>
</AvatarWrapper>

<Dropdown
width={150}
items={
[
{
label: t('input.profileEditor.tabs.avatar.dropdown.selectNFT'),
color: 'black',
onClick: handleSelectOption('nft'),
},
{
label: t('input.profileEditor.tabs.avatar.dropdown.uploadImage'),
color: 'black',
onClick: handleSelectOption('upload'),
},
{
label: t('input.profileEditor.tabs.avatar.dropdown.enterManually'),
color: 'black',
onClick: handleSelectOption('manual'),
},
...(validated
? [
{
label: t('action.remove', { ns: 'common' }),
color: 'red',
onClick: handleSelectOption('remove'),
},
]
: []),
] as DropdownItem[]
}
{...dropdownProps}
>
<ActionContainer>
{!!src && (
<Button disabled colorStyle="accentSecondary">
{src}
</Button>
)}
<div>
<Button colorStyle="accentSecondary">
{t('input.profileEditor.tabs.avatar.change')}
</Button>
</div>
<input
type="file"
style={{ display: 'none' }}
accept="image/*"
ref={fileInputRef}
onChange={(e) => {
if (e.target.files?.[0]) {
onSelectOption?.('upload')
onAvatarFileChange?.(e.target.files[0])
}
}}
/>
</ActionContainer>
</Dropdown>
</Container>
)
}

Expand Down
55 changes: 55 additions & 0 deletions src/components/@molecules/ProfileEditor/Avatar/AvatarManual.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
/* eslint-disable no-multi-assign */

import { useState } from 'react'
import { useTranslation } from 'react-i18next'

import { Button, Dialog, Input } from '@ensdomains/thorin'

type AvatarManualProps = {
avatar?: string
handleCancel: () => void
handleSubmit: (type: 'manual', uri: string, display?: string) => void
}

function isValidValue(value: string, prevValue?: string) {
return !(prevValue && value === prevValue) && !!value.length
}

export function AvatarManual({ avatar, handleCancel, handleSubmit }: AvatarManualProps) {
const { t } = useTranslation('transactionFlow')

const [value, setValue] = useState<string>('')

const handleUpload = async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an upload

try {
handleSubmit('manual', value, value)
} catch (e) {
console.error(e)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the trycatch is unnecessary here, since we are just setting state

}
}

return (
<>
<Dialog.Heading title={t('input.profileEditor.tabs.avatar.dropdown.enterManually')} />
<Dialog.Content>
<Input
label={t('input.profileEditor.tabs.avatar.label')}
value={value}
onChange={(e) => setValue(e.target.value)}
/>
</Dialog.Content>
<Dialog.Footer
leading={
<Button colorStyle="accentSecondary" onClick={() => handleCancel()}>
{t('action.back', { ns: 'common' })}
</Button>
}
trailing={
<Button disabled={!isValidValue(value, avatar)} onClick={handleUpload}>
{t('action.confirm', { ns: 'common' })}
</Button>
}
/>
</>
)
}
Loading
Loading