-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FET-987: new avatar uploader #785
Open
staslysak
wants to merge
12
commits into
main
Choose a base branch
from
FET-987
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
db7cc8d
FET-987: new avatar uploader
0f43724
Merge branch 'main' into FET-987
LeonmanRolls 5db1dc5
adjust mobile dropwdown styles
c17dc9e
avatar button updates
bdee334
added mq
59c796d
added fullwidth
9fef07e
manual avatar flow update
2d969e8
minor cleanup
3350856
tests repair
f9d6cc5
Merge branch 'main' into FET-987
sugh01 ab55d21
avatar button label updates
253656b
Merge branch 'FET-987' of https://github.com/ensdomains/ens-app-v3 in…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
src/components/@molecules/ProfileEditor/Avatar/AvatarManual.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/* eslint-disable no-multi-assign */ | ||
|
||
import { useState } from 'react' | ||
import { useTranslation } from 'react-i18next' | ||
|
||
import { Button, Dialog, Input } from '@ensdomains/thorin' | ||
|
||
type AvatarManualProps = { | ||
avatar?: string | ||
handleCancel: () => void | ||
handleSubmit: (type: 'manual', uri: string, display?: string) => void | ||
} | ||
|
||
function isValidValue(value: string, prevValue?: string) { | ||
return !(prevValue && value === prevValue) && !!value.length | ||
} | ||
|
||
export function AvatarManual({ avatar, handleCancel, handleSubmit }: AvatarManualProps) { | ||
const { t } = useTranslation('transactionFlow') | ||
|
||
const [value, setValue] = useState<string>('') | ||
|
||
const handleUpload = async () => { | ||
try { | ||
handleSubmit('manual', value, value) | ||
} catch (e) { | ||
console.error(e) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i think the trycatch is unnecessary here, since we are just setting state |
||
} | ||
} | ||
|
||
return ( | ||
<> | ||
<Dialog.Heading title={t('input.profileEditor.tabs.avatar.dropdown.enterManually')} /> | ||
<Dialog.Content> | ||
<Input | ||
label={t('input.profileEditor.tabs.avatar.label')} | ||
value={value} | ||
onChange={(e) => setValue(e.target.value)} | ||
/> | ||
</Dialog.Content> | ||
<Dialog.Footer | ||
leading={ | ||
<Button colorStyle="accentSecondary" onClick={() => handleCancel()}> | ||
{t('action.back', { ns: 'common' })} | ||
</Button> | ||
} | ||
trailing={ | ||
<Button disabled={!isValidValue(value, avatar)} onClick={handleUpload}> | ||
{t('action.confirm', { ns: 'common' })} | ||
</Button> | ||
} | ||
/> | ||
</> | ||
) | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not an upload