Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Commit

Permalink
Merge pull request from GHSA-8f9f-pc5v-9r5h
Browse files Browse the repository at this point in the history
feature/migration
  • Loading branch information
decanus authored Jan 30, 2020
2 parents 69204e8 + de1a456 commit 36e10e7
Show file tree
Hide file tree
Showing 13 changed files with 441 additions and 274 deletions.
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,3 @@ _templates

# Compiled contract ABIs and binaries
build/contracts/*
# Keep the ENS lll artifact
!build/contracts/ENS.lll.json
213 changes: 0 additions & 213 deletions build/contracts/ENS.lll.json

This file was deleted.

2 changes: 2 additions & 0 deletions contracts/ENS.lll
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
;;; @title The Ethereum Name Service registry.
;;; @author Daniel Ellison <daniel@syrinx.net>

;;; @deprecated This file is only kept as a reference.

(seq

;; --------------------------------------------------------------------------
Expand Down
10 changes: 8 additions & 2 deletions contracts/ENS.sol
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,19 @@ interface ENS {
// Logged when the TTL of a node changes
event NewTTL(bytes32 indexed node, uint64 ttl);

// Logged when an operator is added or removed.
event ApprovalForAll(address indexed owner, address indexed operator, bool approved);

function setSubnodeOwner(bytes32 node, bytes32 label, address owner) external;
function setRecord(bytes32 node, address owner, address resolver, uint64 ttl) external;
function setSubnodeRecord(bytes32 node, bytes32 label, address owner, address resolver, uint64 ttl) external;

This comment has been minimized.

Copy link
@3esmit

3esmit Jan 30, 2020

Why this one don't returns bytes32? If you changed the other, it should also be here.

function setSubnodeOwner(bytes32 node, bytes32 label, address owner) external returns(bytes32);
function setResolver(bytes32 node, address resolver) external;
function setOwner(bytes32 node, address owner) external;
function setTTL(bytes32 node, uint64 ttl) external;
function setApprovalForAll(address operator, bool approved) external;
function owner(bytes32 node) external view returns (address);
function resolver(bytes32 node) external view returns (address);
function ttl(bytes32 node) external view returns (uint64);

function recordExists(bytes32 node) external view returns (bool);
function isApprovedForAll(address owner, address operator) external view returns (bool);
}
Loading

0 comments on commit 36e10e7

Please sign in to comment.