Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infer method calls on known types and warn about nonexistent methods #11399
Infer method calls on known types and warn about nonexistent methods #11399
Changes from all commits
2715738
c1d4cc1
b284ec5
7968622
f21b783
a1bf4f7
28626fa
9b5a87d
f626367
8aeb690
5c61beb
f5ca4af
435cd0e
8e95c78
218efcd
7594894
9a40731
215a91f
f2b3dd7
273687d
ea15ebc
cafc96d
730e3b9
2aa0377
e39f248
da82e47
52ba2dd
5152227
b7d0fef
94d7323
042edfe
7e7b977
44bfa7d
beba64d
8e58c92
167f9e3
5f2c4aa
02e8275
448c8b2
4cdd9da
d03cba3
64cd1b6
5b23120
23a3828
25f4560
4573289
5a4e057
b21f603
c56c347
2143368
e2f30b2
22db8a6
f6b4638
b98be17
b2c75dc
7cfd7c4
fb5517f
da23709
9dc1268
aa134ab
5181827
157787d
0c202e9
44a4fd0
0e932f4
90fd53a
177e53a
6bb65c1
9df01ef
2cb3fb6
57b6208
70cf5de
6daf829
016d3e1
46e42dd
aa4da65
7d655a4
f90a096
6b621f8
6a2289e
baf4a97
34ef68b
6bf74aa
d936281
4918207
5dbc13a
ef3daa0
bce8508
237af09
1d25d08
855b621
68555a5
990f32f
38c9f78
1563397
d9db891
7719e3e
a912ef4
6eed3eb
ef9095a
bff9a84
fb52dcc
dd0b18b
33a7fac
131116d
981a202
9b43442
4b87f76
57e0859
7794eee
60fff64
436b660
383e2ff
f90f4a2
6519fc1
a437c3e
e994d0c
0aacaf9
ae5dd11
fc88957
efadb43
1b5ffc2
1462e12
1913402
eb9988a
eb8f69e
13c75b0
b7690d5
457a63a
e09047d
894dabc
5f6bf2e
113eec3
5be3b82
4a415cc
3e78eb7
8d060ca
99f6462
29c5fa0
5442d5e
c2c8aee
1e648be
5b22582
d766ae0
179a816
c63abd5
1abd9d6
6b920eb
1c41dd3
10d722b
dfa200b
c270d73
b1331c2
f4485ce
4f0eb2a
9d5deaa
81f9c51
4b08ada
5d09c01
c30f7f0
a1feacc
836a083
1229611
0a3df8b
66e93f7
97fa043
a348219
a8b1505
6b0ce25
9717358
22e6649
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was introducing a new stage:
AFTER_TYPE_INFERENCE_PASSES
, that was supposed to be between two other existing passes. I thought that multiplying the numbers by 10 allows us to introduce such middle stages in the future in an easier manner - one would not need to modify all values as there will still be 'free' integers between existing stage numbers.But I can just bring this back to a natural 0, 1, 2... ordering if that's preferred - please let me know.