-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure EnsoMultiValue returns some Meta.type_of #11480
Conversation
Previously the following was broken: With this PR the first type (e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. But it seems to me that there may be a test missing.
|
||
group_builder.specify "multi_value_as_text_int" <| | ||
v = R.V "hi" 3 . as_text_int | ||
Meta.type_of v . should_equal Text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't you also add test for Meta.type_of v . should_equal Integer
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot right now, as the type doesn't equal Integer
. Currently only the first type is used by type_of
. That's likely to change with the work on
For now, the test checks just the first type.
Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-04): Progress: .
Next Day: Planning & fixes
|
Pull Request Description
Discovered when discussing #11366 - sometimes (when also representing a number) a multi value panics on computing
Meta.type_of
.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,