Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt parse test for Snowflake edge case #12085

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jan 20, 2025

Pull Request Description

Fixing a regression in Snowflake tests.

  • In Snowflake, the Integer type is superseded by Decimal.
  • Thus, a parse test that was checking that parsing a column that already has the right type is na no-op was failing, because on Snowflake the column did not have the 'right type' - we were asking for Integer, but on Snowflake the column had Decimal.
  • To fix this, we change the test to ask exactly for the type that the column has:
    • On most backends this will still ask for Integer.
    • On Snowflake this will ask for Decimal and ensure the conversion is still a no-op.
  • Due to Snowflake's differences, parse Integer won't work as easily as on other platforms, the user has to ask for Decimal.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 20, 2025
@radeusgd
Copy link
Member Author

radeusgd commented Jan 20, 2025

@radeusgd radeusgd added CI: Ready to merge This PR is eligible for automatic merge and removed CI: Ready to merge This PR is eligible for automatic merge labels Jan 21, 2025
@mergify mergify bot merged commit 242c27d into develop Jan 21, 2025
50 checks passed
@mergify mergify bot deleted the wip/radeusgd/fix-snowflake-01-20 branch January 21, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants