-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New icon component #12091
Merged
Merged
New icon component #12091
+315
−193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Storybook is successfully deployed!📊 Dashboard:
|
6b4dd1e
to
95f55ef
Compare
MrFlashAccount
commented
Jan 29, 2025
@@ -15,7 +15,7 @@ await fs.writeFile( | |||
// Please run \`bazel run //:write_all\` to regenerate this file whenever \`icons.svg\` is changed. | |||
/** All icon names present in icons.svg. */ | |||
const iconNames = [ | |||
export const iconNames = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added export here to have a canvas with all icons in Storybook
PabloBuchu
approved these changes
Jan 31, 2025
somebody1234
reviewed
Feb 3, 2025
* @deprecated Prefer defined keys over importing from `#/assets/*.svg | ||
*/ | ||
export type LegacyIconProp<Icon extends string, Render> = | ||
| LegacyAvialableIconReturn<Icon> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be Available
somebody1234
approved these changes
Feb 3, 2025
jdunkerley
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: No changelog needed
Do not require a changelog entry for this PR.
CI: Ready to merge
This PR is eligible for automatic merge
g-dashboard
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds support for icons generated from figma and deprecates the imports from
#/assets/
folderCloses: #12062
Note: This PR does not migrate any icons. It only deprecates the legacy approach. Migrations will be done in future PRs.
Please refer to Storybook for visual review. Also this PR adds a canvas with all icons.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.