Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New icon component #12091

Merged
merged 15 commits into from
Feb 3, 2025
Merged

New icon component #12091

merged 15 commits into from
Feb 3, 2025

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Jan 21, 2025

Pull Request Description

This PR adds support for icons generated from figma and deprecates the imports from #/assets/ folder

Closes: #12062


Note: This PR does not migrate any icons. It only deprecates the legacy approach. Migrations will be done in future PRs.

Please refer to Storybook for visual review. Also this PR adds a canvas with all icons.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

Sorry, something went wrong.

@MrFlashAccount MrFlashAccount added CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard labels Jan 21, 2025
@MrFlashAccount MrFlashAccount self-assigned this Jan 21, 2025
Copy link

github-actions bot commented Jan 21, 2025

🧪 Storybook is successfully deployed!

📊 Dashboard:

Verified

This commit was signed with the committer’s verified signature.
@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/icons-rework branch from 6b4dd1e to 95f55ef Compare January 29, 2025 10:38

Unverified

This user has not yet uploaded their public signing key.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@@ -15,7 +15,7 @@ await fs.writeFile(
// Please run \`bazel run //:write_all\` to regenerate this file whenever \`icons.svg\` is changed.
/** All icon names present in icons.svg. */
const iconNames = [
export const iconNames = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added export here to have a canvas with all icons in Storybook

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@MrFlashAccount MrFlashAccount added the CI: Ready to merge This PR is eligible for automatic merge label Jan 31, 2025
@jdunkerley jdunkerley added the CI: Keep up to date Automatically update this PR to the latest develop. label Feb 3, 2025

Verified

This commit was signed with the committer’s verified signature.
@jdunkerley jdunkerley removed the CI: Keep up to date Automatically update this PR to the latest develop. label Feb 3, 2025
@MrFlashAccount MrFlashAccount added CI: Keep up to date Automatically update this PR to the latest develop. and removed CI: Keep up to date Automatically update this PR to the latest develop. labels Feb 3, 2025

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
* @deprecated Prefer defined keys over importing from `#/assets/*.svg
*/
export type LegacyIconProp<Icon extends string, Render> =
| LegacyAvialableIconReturn<Icon>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be Available

Verified

This commit was signed with the committer’s verified signature.
try

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@mergify mergify bot merged commit 36d967e into develop Feb 3, 2025
38 of 42 checks passed
@mergify mergify bot deleted the wip/sergeigarin/icons-rework branch February 3, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One source for icons for Project View and Dashboard.
4 participants