Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENSO_LAUNCHER can be native,test,debug,fast,-ls #12117

Merged
merged 15 commits into from
Jan 24, 2025

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Jan 23, 2025

Pull Request Description

Fixes another issue related to #12014 - runEngineDistribution has to generate native image launchers when in ENSO_LAUNCHER=native mode. This PR also introduces additional comma separated values to the ENSO_LAUNCHER variable:

  • shell uses shell launchers and has no additional sub options
  • native generates some form of native image launchers
  • concatenations are possible:
    • fast,native disables code optimizations to speed the build up
    • test,native enables assertions
    • debug,native enables debug information
    • combinations up to native,test,debug,fast are also possible

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    Rust
    style guides.
  • Manually tested runEngineDistribution and buildEngineDistribution
  • CI continues to work

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 23, 2025
@JaroslavTulach JaroslavTulach self-assigned this Jan 23, 2025
@JaroslavTulach JaroslavTulach changed the title Wip/jtulach/fancy enso launcher ENSO_LAUNCHER can be fastnative & co. Jan 23, 2025
Copy link
Member

@Akirathan Akirathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing more fine-grained configuration for how to build the native image of engine-runner is a good idea. I don't like the string concatenations in ENSO_LAUNCHER env var. Seems too cryptic.

build.sbt Show resolved Hide resolved
docs/infrastructure/native-image.md Outdated Show resolved Hide resolved
@JaroslavTulach JaroslavTulach force-pushed the wip/jtulach/FancyEnsoLauncher branch from 598c287 to 51b5fb2 Compare January 23, 2025 11:06
@JaroslavTulach JaroslavTulach changed the title ENSO_LAUNCHER can be fastnative & co. ENSO_LAUNCHER can be native,test,debug,fast Jan 23, 2025
@JaroslavTulach JaroslavTulach added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Jan 23, 2025
@JaroslavTulach
Copy link
Member Author

JaroslavTulach commented Jan 24, 2025

Windows build is failing because we are searching for enso.bat and there is only enso.exe. Let 9acc533 and 69d8944 be the fixes!

@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Jan 24, 2025
@enso-bot enso-bot bot mentioned this pull request Jan 24, 2025
@JaroslavTulach
Copy link
Member Author

What's happening on windows and on linux?

 INFO ide_ci::program::command: cmd ℹ️ AAAo
 INFO ide_ci::program::command: cmd ⚠️ AAAo
 INFO ide_ci::program::command: cmd ⚠️ java.lang.Exception
 INFO ide_ci::program::command: cmd ⚠️ 	at org.enso.table.excel.ExcelConnectionPool.release(ExcelConnectionPool.java:206)

 INFO ide_ci::program::command: bash ℹ️     - [FAILED] (S3_File) Will always download a file for mode Always [7841ms]
 INFO ide_ci::program::command: bash ℹ️         Reason: An unexpected error was returned: (Already_Exists (File_Like.Value s3://enso-ci-s3-test-stage/data_spec/always.txt))

 INFO ide_ci::program::command: bash ℹ️ AAAo
 INFO ide_ci::program::command: bash ⚠️ AAAo
 INFO ide_ci::program::command: bash ⚠️ java.lang.Exception
 INFO ide_ci::program::command: bash ⚠️ 	at org.enso.table.excel.ExcelConnectionPool.release(ExcelConnectionPool.java:206)
 INFO ide_ci::program::command: bash ⚠️ 	at org.enso.table.excel.ReadOnlyExcelConnection.close(ReadOnlyExcelConnection.java:26)
 INFO ide_ci::program::command: bash ⚠️ 	at org.graalvm.truffle/com.oracle.truffle.host.HostMethodDesc$SingleMethod$MHBase.invokeHandle(HostMethodDesc.java:371)
 INFO ide_ci::program::command: bash ⚠️ 	at org.graalvm.truffle/

Everybody loves CI fighting!

@JaroslavTulach JaroslavTulach added the CI: Keep up to date Automatically update this PR to the latest develop. label Jan 24, 2025
@JaroslavTulach JaroslavTulach changed the title ENSO_LAUNCHER can be native,test,debug,fast ENSO_LAUNCHER can be native,test,debug,fast,-ls Jan 24, 2025
@mergify mergify bot merged commit 8cc8c4f into develop Jan 24, 2025
49 checks passed
@mergify mergify bot deleted the wip/jtulach/FancyEnsoLauncher branch January 24, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Keep up to date Automatically update this PR to the latest develop. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants