-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENSO_LAUNCHER
can be native,test,debug,fast,-ls
#12117
Conversation
…chers (and doesn't index) if launchers are missing
ENSO_LAUNCHER
can be fastnative
& co.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Providing more fine-grained configuration for how to build the native image of engine-runner
is a good idea. I don't like the string concatenations in ENSO_LAUNCHER
env var. Seems too cryptic.
598c287
to
51b5fb2
Compare
ENSO_LAUNCHER
can be fastnative
& co.ENSO_LAUNCHER
can be native,test,debug,fast
Windows build is failing because we are searching for enso.bat and there is only enso.exe. Let 9acc533 and 69d8944 be the fixes! |
What's happening on windows and on linux?
Everybody loves CI fighting! |
ENSO_LAUNCHER
can be native,test,debug,fast
ENSO_LAUNCHER
can be native,test,debug,fast,-ls
Pull Request Description
Fixes another issue related to #12014 -
runEngineDistribution
has to generate native image launchers when inENSO_LAUNCHER=native
mode. This PR also introduces additional comma separated values to theENSO_LAUNCHER
variable:shell
uses shell launchers and has no additional sub optionsnative
generates some form of native image launchersfast,native
disables code optimizations to speed the build uptest,native
enables assertionsdebug,native
enables debug informationnative,test,debug,fast
are also possibleChecklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
Rust
style guides.
runEngineDistribution
andbuildEngineDistribution