Use fn... to reference any module function

CHANGELOG.md

@@ -46,6 +46,7 @@
 - [Types without constructors can be public][12052]
 - Symetric, transitive and reflexive [equality for intersection types][11897]
 - [IR definitions are generated by an annotation processor][11770]
+- [Use fn... to reference any module function](12128)
 
 [11777]: https://github.com/enso-org/enso/pull/11777
 [11600]: https://github.com/enso-org/enso/pull/11600
@@ -55,6 +56,7 @@
 [12052]: https://github.com/enso-org/enso/pull/12052
 [11897]: https://github.com/enso-org/enso/pull/11897
 [11770]: https://github.com/enso-org/enso/pull/11770
+[12128]: https://github.com/enso-org/enso/pull/12128
 
 # Enso 2024.5
 

engine/runtime-compiler/src/main/scala/org/enso/compiler/pass/resolve/GlobalNames.scala

@@ -340,26 +340,41 @@ case object GlobalNames extends IRPass {
       )
     )
     processedFun.getMetadata(this) match {
-      case Some(Resolution(ResolvedModuleMethod(mod, _))) if !isLocalVar(fun) =>
-        val self = freshNameSupply
-          .newName()
-          .updateMetadata(
-            new MetadataPair(
-              this,
-              BindingsMap.Resolution(
-                BindingsMap.ResolvedModule(mod)
+      case Some(Resolution(resMethod @ ResolvedModuleMethod(mod, _)))
+          if !isLocalVar(fun) =>
+        if (app.hasDefaultsSuspended && app.arguments.isEmpty) {
+          app
+            .updateMetadata(
+              new MetadataPair(
+                this,
+                BindingsMap.Resolution(resMethod)
               )
             )
+
+        } else {
+          val self = freshNameSupply
+            .newName()
+            .updateMetadata(
+              new MetadataPair(
+                this,
+                BindingsMap.Resolution(
+                  BindingsMap.ResolvedModule(mod)
+                )
+              )
+            )
+          val selfArg =
+            new CallArgument.Specified(
+              None,
+              self,
+              true,
+              identifiedLocation = null
+            )
+          processedFun.passData.remove(this) // Necessary for IrToTruffle
+          app.copy(
+            function  = processedFun,
+            arguments = selfArg :: processedArgs
           )
-        val selfArg =
-          new CallArgument.Specified(
-            None,
-            self,
-            true,
-            identifiedLocation = null
-          )
-        processedFun.passData.remove(this) // Necessary for IrToTruffle
-        app.copy(function = processedFun, arguments = selfArg :: processedArgs)
+        }
       case _ =>
         app.copy(function = processedFun, arguments = processedArgs)
     }

engine/runtime-integration-tests/src/test/java/org/enso/interpreter/test/semantic/FunctionIdentityTest.java

@@ -0,0 +1,89 @@
+package org.enso.interpreter.test.semantic;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
+
+import com.oracle.truffle.api.interop.InteropLibrary;
+import java.nio.file.Paths;
+import java.util.Map;
+import java.util.logging.Level;
+import org.enso.common.RuntimeOptions;
+import org.enso.interpreter.runtime.callable.function.Function;
+import org.enso.test.utils.ContextUtils;
+import org.graalvm.polyglot.Context;
+import org.graalvm.polyglot.Language;
+import org.graalvm.polyglot.Source;
+import org.graalvm.polyglot.io.IOAccess;
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+public class FunctionIdentityTest {
+
+  private Context ctx;
+
+  @Before
+  public void initContext() {
+    ctx =
+        Context.newBuilder()
+            .allowExperimentalOptions(true)
+            .option(
+                RuntimeOptions.LANGUAGE_HOME_OVERRIDE,
+                Paths.get("../../distribution/component").toFile().getAbsolutePath())
+            .option(RuntimeOptions.LOG_LEVEL, Level.WARNING.getName())
+            .logHandler(System.err)
+            .allowExperimentalOptions(true)
+            .allowIO(IOAccess.ALL)
+            .allowAllAccess(true)
+            .build();
+
+    var engine = ctx.getEngine();
+    Map<String, Language> langs = engine.getLanguages();
+    Assert.assertNotNull("Enso found: " + langs, langs.get("enso"));
+  }
+
+  @After
+  public void disposeContext() {
+    ctx.close();
+    ctx = null;
+  }
+
+  @Test
+  public void functionWithArgIdentity() throws Exception {
+    var rawCode = """
+        am_i_me _ = am_i_me...
+        """;
+    assertFunctionIdentity(rawCode, "Am_I_Me_With_Arg");
+  }
+
+  @Test
+  public void functionIdentity() throws Exception {
+    var rawCode = """
+        am_i_me = am_i_me...
+        """;
+    assertFunctionIdentity(rawCode, "Am_I_Me");
+  }
+
+  private void assertFunctionIdentity(String code, String moduleName) throws Exception {
+    var src = Source.newBuilder("enso", code, moduleName + ".enso").build();
+    var module = ctx.eval(src);
+    var fn = module.invokeMember("eval_expression", "am_i_me").execute(0);
+
+    assertTrue("fn: " + fn, fn.canExecute());
+
+    var rawFn = ContextUtils.unwrapValue(ctx, fn);
+    assertTrue("is Function: " + rawFn, rawFn instanceof Function);
+
+    var iop = InteropLibrary.getUncached();
+    assertEquals(moduleName + ".am_i_me", iop.getExecutableName(rawFn));
+    assertTrue("Has location", iop.hasSourceLocation(rawFn));
+    var loc = iop.getSourceLocation(rawFn);
+    assertNotNull("Location found", loc);
+    assertEquals(
+        "am_i_me function definition is on the first line",
+        code.split("\n")[0],
+        loc.getCharacters().toString());
+  }
+}

engine/runtime/src/main/java/org/enso/interpreter/runtime/callable/function/Function.java

@@ -2,6 +2,7 @@
 
 import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.CompilerDirectives.CompilationFinal;
+import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.RootCallTarget;
 import com.oracle.truffle.api.dsl.Bind;
 import com.oracle.truffle.api.dsl.Cached;
@@ -133,13 +134,16 @@ public RootCallTarget getCallTarget() {
   /**
    * @return the name of this function.
    */
+  @TruffleBoundary
   public String getName() {
     return getCallTarget().getRootNode().getName();
   }
 
   /**
    * @return the source section this function was defined in.
    */
+  @TruffleBoundary
+  @ExportMessage(name = "getSourceLocation")
   public SourceSection getSourceSection() {
     return getCallTarget().getRootNode().getSourceSection();
   }
@@ -191,6 +195,21 @@ boolean isExecutable() {
     return true;
   }
 
+  @ExportMessage
+  boolean hasSourceLocation() {
+    return getSourceSection() != null;
+  }
+
+  @ExportMessage
+  boolean hasExecutableName() {
+    return this.getName() != null;
+  }
+
+  @ExportMessage
+  String getExecutableName() {
+    return this.getName();
+  }
+
   /**
    * A class representing the executable behaviour of the function.
    *

engine/runtime/src/main/scala/org/enso/interpreter/runtime/IrToTruffle.scala

@@ -2028,9 +2028,15 @@ class IrToTruffle(
             asScope(symbol.module.unsafeAsModule())
               .getPolyglotSymbolSupplier(name)
           LazyObjectNode.build(name, s)
-        case BindingsMap.ResolvedModuleMethod(_, method) =>
-          throw new CompilerError(
-            s"Impossible here, module method ${method.name} should be caught when translating application"
+        case BindingsMap.ResolvedModuleMethod(module, method) =>
+          LazyObjectNode.build(
+            method.name,
+            () => {
+              val typ   = asAssociatedType(module.unsafeAsModule())
+              val scope = asScope(module.unsafeAsModule())
+              val fn    = scope.getMethodForType(typ, method.name)
+              fn
+            }
           )
         case BindingsMap.ResolvedExtensionMethod(_, staticMethod) =>
           throw new CompilerError(