Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8830 add google analytics authentication and reporting to enso #8907

Merged

Conversation

Cassandra-Clark
Copy link
Contributor

Pull Request Description

Updates Google_Api version for authentication and adds Google Analytics reporting api and run_google_report method.

This is an initial method for proof of concept, with further design changes to follow.

Important Notes

Updates google-api-client to v 2.2.0 from 1.35.2
Adds google-analytics-data v 0.44.0

Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I've got one nit but it's a minor one, can be ignored.

@radeusgd
Copy link
Member

radeusgd commented Feb 7, 2024

I have updated the branch so that the reviews should be passing.

I still need someone to double check if the license for javax.annotations is OK as it is not a standard license we used before, so I cannot really take responsibility for accepting it.

I'm also not sure about the com.google.code.findbugs.jsr305 dependency. I know we have excluded it in the past due to uncertainities about its licensing. I've seen mentions on the Guava repo that it might be incompatible with the Oracle license. I think I'd try to exclude it from the dependencies and see if the Google_Api still works.

@radeusgd
Copy link
Member

radeusgd commented Feb 7, 2024

I tried removing the jsr305 as we also were excluding it elswhere and it seemed to work.

@Cassandra-Clark could you please:

  1. verify that your workflow still works correctly with the change I did to the jsr dependency?
  2. could you check / find someone who could check that CDDL license for javax.annotations that we have here?

@Cassandra-Clark
Copy link
Contributor Author

I tried removing the jsr305 as we also were excluding it elswhere and it seemed to work.

@Cassandra-Clark could you please:

1. verify that your workflow still works correctly with the change I did to the jsr dependency?

2. could you check / find someone who could check that [CDDL license](https://github.com/enso-org/enso/pull/8907/files#diff-6cefea679d12e05219a0e3a93eafb8b776a0bce49ef1dc78619786618fd34917) for `javax.annotations` that we have here?

workflow still works after this change! CDDL license is under review now.

@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Feb 13, 2024
@mergify mergify bot merged commit 88c1cc1 into develop Feb 13, 2024
26 of 29 checks passed
@mergify mergify bot deleted the 8830-add-google-analytics-authentication-and-reporting-to-enso branch February 13, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Google Analytics Authentication and Reporting to enso
6 participants