-
Notifications
You must be signed in to change notification settings - Fork 34
API update to support the newly added reexport field. #1718
base: wip/ao/api-update
Are you sure you want to change the base?
Conversation
…preloaded and does not delay showing visualisations.
f54f57b
to
4e97ee7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I don't like is the name. The export suggest that this an exporting line, and adding re- is confusing even more. Does if the module containing the object "re-export" this? Or maybe: does it mean, that the field will be filled only when the object is re-exported, and will be empty if only module containing it export it?
The logic behind the re-export naming is that every module implicitly exports all its definitions. Another module can re-export symbols that were defined in a different module. So, this re prefix only tells that this module is not the one where the symbol was defined. |
c113e31
to
c4436d3
Compare
Ok, so in case when no module re-export given symbol, the |
@mwu-tow What is the status of this PR? Should it be updated/finished, or is it abandoned and should be closed? |
@MichaelMauderer Likely the missing pieces should be manually merged back. |
This PR must have fallen through the cracks during the release process back then. Can you bring this PR up to date or create a new PR with the things that still need to be merged? (After checking with planning about priorities) |
Pull Request Description
IDE support for enso-org/enso#1793
Important Notes
This PR is based on Adam's API updated, as they are necessary for newer engine versions.
Will refrain from testing scenarios until "actual" merge is possible.
New field is not actually "used" (as in leading to visible user change), this PR only introduces API support.
Checklist
Please include the following checklist in your PR:
~- [ ] The
CHANGELOG.md
was updated with the changes introduced in this PR. ~- [ ] All code has been profiled where possible.- [ ] All code has been manually tested in the "debug/interface" scene.