This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
Argument Names in the Span Tree #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unction arguments.
…vocations of known arity
farmaazon
reviewed
Sep 9, 2020
Comment on lines
+149
to
+161
| let chain = infix.flatten(); | ||
| let app_base = ApplicationBase::new(self); | ||
| let invocation = || -> Option<CalledMethodInfo> { | ||
| context.call_info(self.id?, app_base.function_name) | ||
| }(); | ||
|
|
||
| // All prefix params are missing arguments, since there is no prefix application. | ||
| let missing_args = app_base.prefix_params(invocation); | ||
| let arity = missing_args.len(); | ||
| let base_node_kind = if arity==0 {kind} else {node::Kind::Operation}; | ||
| let node = chain.generate_node(base_node_kind,context)?; | ||
| let provided_prefix_arg_count = 0; | ||
| Ok(generate_expected_arguments(node,kind,provided_prefix_arg_count,missing_args)) |
There was a problem hiding this comment.
The infix could be a function part of prefix chain - and possibly we could generate ports for arguments twice (all depends of definition of "expression being a call". Let's discuss this case on the call.
There was a problem hiding this comment.
Leaving as-is for now, as discussed.
Current language server behavior is that it provides a method pointer only for fully saturated calls.
src/rust/ide/src/controller/graph.rs
Outdated
Comment on lines
510
to
524
| /// | ||
| /// Will use `self` as the context for span tree generation. | ||
| pub fn connections_unevaluated_ctx(&self) -> FallibleResult<Connections> { | ||
| let graph = self.graph_info()?; | ||
| Ok(Connections::new(&graph,self)) | ||
| } | ||
|
|
||
| /// Returns information about all the connections between graph's nodes. | ||
| pub fn connections | ||
| (&self, context:&impl SpanTreeContext) -> FallibleResult<Connections> { | ||
| let graph = self.graph_info()?; | ||
| Ok(Connections::new(&graph)) | ||
| // TODO perhaps this should merge given context with the metadata information | ||
| // or perhaps this should just do exactly what it is told | ||
| Ok(Connections::new(&graph,context)) | ||
| } |
There was a problem hiding this comment.
I would make functions:
connections(self)- to provide connections with data from metadataconnections_enriched(self, context)- to apply result of context before metadata - being used by executed graph.
There was a problem hiding this comment.
Leaving as-is, as discussed. For now that for consistency would require providing a number of mostly duplicated unused methods.
If ever needed, then they can provided or alternatively a design where graph controller holds context as a field should be reconsidered.
farmaazon
approved these changes
Sep 10, 2020
Co-authored-by: Adam Obuchowicz <adam.obuchowicz@luna-lang.org>
Co-authored-by: Adam Obuchowicz <adam.obuchowicz@luna-lang.org>
Co-authored-by: Adam Obuchowicz <adam.obuchowicz@luna-lang.org>
…to wip/mwu/arg-names
mwu-tow
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds information about argument names and types to the span tree nodes.
The arguments are recognized based on the intended method metadata entry (if present and name matches) or the computed value registry.
This is feature complete PR. Still more tests are intended.
Important Notes
Checklist
Please include the following checklist in your PR: