Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privatize columns used in cursors predicates #537

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

amrnt
Copy link
Contributor

@amrnt amrnt commented Jul 19, 2023

No description provided.

Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, I don't see any problems merging this. But are you able to reproduce this somehow with a test or just elaborate where does it fail?

@amrnt
Copy link
Contributor Author

amrnt commented Jul 20, 2023

Using multi order, It does fail when for instance having Paginate chained to Modify with joins for example, and the order fields does exist in both (or more) tables.

The error was eg:

panic: [{"message":"ambiguous column name: status","path":["todosWithJoins"]}]

I added a test case

@amrnt
Copy link
Contributor Author

amrnt commented Jul 21, 2023

@a8m does the latest push satisfies the PR?

Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Thanks, @amrnt.

@a8m a8m merged commit 02db1ac into ent:master Jul 21, 2023
@amrnt amrnt deleted the privatize-cursors-predicates branch July 21, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants