This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Properly handle template branch names that contain a forward slash #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
templateBranchName
is a branch containing a forward slash (e.g.dev/v1.0
) this leads to errors when trying to retrieve the job's config from Jenkins (since Jenkins interprets the/
as part of the URL and therefore throws a 404). This PR runs thetemplateBranchName
through the same conversion (/
->_
) as the job names created from git branches. Thus, for atemplateBranchName
like the above example, the expected name of the template job isdev_v1.0
, matching the general pattern the script expects.