Merge pull request #1581 from entando/ENG-5354_uniqueIDs

ENG-5354 fix pages and widgets dropdown IDs
entando · Dec 12, 2023 · 7003560 · 7003560
2 parents dc56e37 + 1d49863
commit 7003560
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/ui/pages/common/PageTreeActionMenu.js b/src/ui/pages/common/PageTreeActionMenu.js
@@ -98,7 +98,7 @@ class PageTreeActionMenu extends Component {
 
     return (
       <div onClick={e => e.stopPropagation()} role="none" data-testid={`${page.code}-actions`}>
-        <DropdownKebab pullRight id="WidgetListRow-dropown">
+        <DropdownKebab pullRight id={`WidgetListRow-dropdown-${page.code}`}>
           <MenuItem
             className="PageTreeActionMenuButton__menu-item-add"
             onSelect={this.handleClick(onClickAdd)}

diff --git a/src/ui/pages/config/WidgetFrame.js b/src/ui/pages/config/WidgetFrame.js
@@ -52,7 +52,7 @@ class WidgetFrame extends Component {
 
       actionsMenu = (
         <DropdownKebab
-          id="WidgetFrame__menu-button"
+          id={`WidgetFrame__menu-button-${frameName.replace(/\s/g, '_')}`}
           className="WidgetFrame__menu-button"
           pullRight
         >

diff --git a/src/ui/widgets/detail/DetailWidgetElement.js b/src/ui/widgets/detail/DetailWidgetElement.js
@@ -31,7 +31,7 @@ const DetailWidgetElement = ({ widgetInfo }) => {
             </td>
             <td className="DetailWidgetElement__td text-center">{data[info].frameDraft}</td>
             <td className="DetailWidgetElement__td text-center">
-              <DropdownKebab pullRight id="DetailWidgetElement-dropown">
+              <DropdownKebab pullRight id={`DetailWidgetElement-dropdown-${info}`}>
                 <LinkMenuItem
                   id={`go-page-detail-${info}`}
                   to={routeConverter(ROUTE_PAGE_CONFIG, { pageCode: info })}

diff --git a/src/ui/widgets/list/WidgetListTable.js b/src/ui/widgets/list/WidgetListTable.js
@@ -80,7 +80,7 @@ export const WidgetListTableBody = ({
       const { values: { code }, original: { locked, hasConfig } } = cellinfo;
       return (
         <div data-testid={`${code}-actions`}>
-          <DropdownKebab pullRight id={`WidgetListRow-dropown-${code}`}>
+          <DropdownKebab pullRight id={`WidgetListRow-dropdown-${code}`}>
             {hasConfig && (
               <MenuItem
                 className="WidgetListRow__menu-item-addwidget"