ENG-5114 integration API /userProfiles/avatar to upload the avatar #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichalagashvili
requested changes
Dec 19, 2023
src/state/avatar/actions.js
Outdated
Comment on lines
5
to
13
| export const getBase64 = file => ( | ||
| new Promise((resolve) => { | ||
| const reader = new FileReader(); | ||
| reader.readAsDataURL(file); | ||
| reader.onload = () => { | ||
| const base64 = reader.result.split(','); | ||
| resolve(base64[1]); | ||
| }; | ||
| })); |
There was a problem hiding this comment.
This function already exists on line 36 in src\state\file-browser\actions.js
src/state/avatar/actions.js
Outdated
Comment on lines
24
to
25
| const requestObject = await createFileObject(avatar); | ||
| dispatch(toggleLoading(loader)); |
There was a problem hiding this comment.
I think toggle loading should be above the await line
| method: METHODS.DELETE, | ||
| mockResponse: FILE_BROWSER_FILE, | ||
| useAuthentication: true, | ||
| }); |
There was a problem hiding this comment.
Please add a new line at the end of the file
| expect(dispatch).toHaveBeenCalledWith({ type: 'errors/add-errors', payload: { errors: TypeError('[TypeError: Failed to execute \'readAsDataURL\' on \'FileReader\': parameter 1 is not of type \'Blob\'.]') } }); | ||
| expect(dispatch).toHaveBeenCalledTimes(3); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Please add a new line at the end of the file
| dispatch(addErrors(error)); | ||
| dispatch(addToast(message, TOAST_ERROR)); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Please add a new line at the end of the file
ichalagashvili
previously approved these changes
Dec 19, 2023
|
Requested publication of version |
ichalagashvili
previously approved these changes
Dec 20, 2023
|
Requested publication of version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.