Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshots Data Masking #45

Merged
merged 2 commits into from
Oct 9, 2022
Merged

Snapshots Data Masking #45

merged 2 commits into from
Oct 9, 2022

Conversation

jonhopper-dataengineers
Copy link
Contributor

added the ability to apply data masking to snapshot tables.

we needed to be able to apply table data masking which has been created via a snapshot. modified the "models" path to include "model" and "snapshot" as the resource types.

added in the snapshots post-hook into the docs to be able to apply the mask.

* added in ability to process snapshots

* added unapply resource type for snapshots
@entechlog
Copy link
Owner

entechlog commented Oct 5, 2022

@jonhopper-dataengineers,

  • Thank You for the change
  • Reviewed the changes visually and is looking good
  • Do you also have the ability to include test results to this PR ?

@entechlog entechlog self-requested a review October 5, 2022 06:12
@jonhopper-dataengineers
Copy link
Contributor Author

@jonhopper-dataengineers,

  • Thank You for the change
  • Reviewed the changes visually and is looking good
  • Do you also have the ability to include test results to this PR ?

I have added a snapshot and applied the masking to it .. is that what you meant?
image

email address was used as the column for the mask ... so it follows the functionality in the model example of the same data

@entechlog
Copy link
Owner

@jonhopper-dataengineers , Yes and Thank You. Did you also test removing mask as well ?

@jonhopper-dataengineers
Copy link
Contributor Author

@jonhopper-dataengineers , Yes and Thank You. Did you also test removing mask as well ?

Yes I did. Works a treat.

@entechlog
Copy link
Owner

Thanks @jonhopper-dataengineers , Merging this change now and will create a release

@entechlog entechlog merged commit 307c8ab into entechlog:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants