update-rpm-lock: use volumes instead of mounts #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On systems where SELinux is enabled, it is not possible to modify file on the host's filesystem unless explicitly enabled by SELinux. The `--mount` flag does not allow specifying SELinux labels. This commit changes the podman run command to use `--volume` instead so the labels can be set as expected. Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2175 +/- ##
=======================================
Coverage 71.22% 71.22%
=======================================
Files 89 89
Lines 7479 7479
=======================================
Hits 5327 5327
Misses 2152 2152
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joejstuart
approved these changes
Nov 18, 2024
zregvart
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On systems where SELinux is enabled, it is not possible to modify file on the host's filesystem unless explicitly enabled by SELinux. The
--mountflag does not allow specifying SELinux labels. This commit changes the podman run command to use--volumeinstead so the labels can be set as expected.