Update Conftest to v0.43.1 #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #801 +/- ##
==========================================
- Coverage 77.48% 74.34% -3.14%
==========================================
Files 53 55 +2
Lines 4632 4736 +104
==========================================
- Hits 3589 3521 -68
- Misses 1043 1215 +172
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Seems we were impacted by this change in OPA. This bit of code is trying to parse any task result in the pipeline, some of which will not be valid JSON... |
|
What should we do here? Close it for now? Move it to draft? Rebase? |
|
I'll rebase this, the feedback as to what is broken helps |
zregvart
force-pushed
the
pr/upstream-conftest-version
branch
from
8ad123f to
3087c1c
Compare
We no longer need the workaround and can use the upstream version.
zregvart
force-pushed
the
pr/upstream-conftest-version
branch
from
3087c1c to
9b41ae8
Compare
|
enterprise-contract/ec-policies#546 fixed the last issue here, this is now ready to be merged |
lcarva
approved these changes
Jul 14, 2023
zregvart
added a commit
to zregvart/e2e-tests
that referenced
this pull request
Jul 19, 2023
This upgrades EC release policy to the latest version which includes a fix[1] needed for the upgraded version of OPA in[2]. The proper fix would not use a pinned version of rules/data but rely on the defaults from the `enterprise-contract/default` ConfigMap, as used in other scenarios. This is not possible at the moment because we need a change[3] that restores the missing acceptable bundles merged first. [1] enterprise-contract/ec-policies#546 [2] enterprise-contract/ec-cli#801 [3] redhat-appstudio/infra-deployments#2130
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need the workaround and can use the upstream version.